Discord withVencord override not working

kutu-dev commented 2 months ago

Describe the bug

Vencord settings at Discord doesn't appear when using the override on aarch64-darwin

Steps To Reproduce

Steps to reproduce the behavior: Set up Discord with the override on Home Manager:

home.packages = with pkgs; [
    neovim
    just
    fish
    eza
    fortune
    wezterm
    (discord.override {
      withVencord = true;
    })
  ];

Expected behavior

Be able to access the Vencord options in the Discord settings.

Screenshots

Notify maintainers

@Scrumplex @artturin @infinidoge @jopejoe1

Metadata

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.2.0, macOS 14.2`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.2`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

Infinidoge commented 2 months ago

What version of nixpkgs are you using? This was a Vencord bug that got fixed in recent versions of Vencord. The nixpkgs-unstable should work properly as far as I am aware.

kutu-dev commented 2 months ago

As far as I know I've set up right the unstable in my flake:

inputs = {
  nixpkgs.url = "github:nixos/nixpkgs?ref=nixos-unstable";
}

kutu-dev commented 2 months ago

I think it may be related with nix-darwin, this is how i'm setting it right now: https://github.com/kutu-dev/nubosa/blob/090b1a0c260d8caa1395c39436032d17f32c7933/modules/macos/darwin.nix

Scrumplex commented 2 months ago

It is possible that it doesn't work on darwin :O

kutu-dev commented 2 months ago

There is some sort of package that reports which nixpkgs channel was use to install it? Just to be sure is not an issue on my side, by the way withOpenASAR works just fine so overriding is not the problem by itself.

Edit: I tried to install a package only available at unstable and it work so it seems that the issue is with the package.

I've also check if the commands that should run with the option activated worked https://github.com/NixOS/nixpkgs/blob/cd7ec2419a9a98e9119d64f5b0cbaa069e53c298/pkgs/applications/networking/instant-messengers/discord/darwin.nix#L28-L33 and after extracting the ASAR file it's just like a vanilla discord install, I've tested it before letting Discord update itself so it seems it isn't related.

Scrumplex commented 2 months ago

I just tested this on my work MacBook, and it seems to work fine. Is it possible that you still have a previous (non-Nix) Discord version that interferes here?

kutu-dev commented 2 months ago

No luck so far, I've removed everything with Discord in its name that fzf reported to not be in a nix related directory. The Discord logs doen't say anything related with Vencord. I'm in a Macbook Air M2 if this helps.

Qyriad commented 2 months ago

As far as I know I've set up right the unstable in my flake:

That could still be a nixos-unstable locked before the fix.

When was the last time you updated that Nixpkgs input in your flake lockfile, and/or what commit is listed in the lockfile entry for Nixpkgs?

Rexcrazy804 commented 2 months ago

I kinda have a similar issue with overriding Vencord, whenever I try to open the settings page it crashes with the following:

I initially expected it to be an issue with openAsar but after disabling the open asar override the error persists. It works as expected with the vencord override disabled.

Infinidoge commented 2 months ago

With the latest Discord updates, Vencord is currently completely broken for reasons that are unrelated to Nix.

pluiedev commented 2 months ago

I kinda have a similar issue with overriding Vencord, whenever I try to open the settings page it crashes with the following:

This is caused by a breaking change from upstream Discord — see https://github.com/Vendicated/Vencord/issues/2584. This issue should be reserved for Nix-specific problems only.

Also, @kutu-dev has the issue ever been fixed on your end? If so, I think this issue could be closed

kutu-dev commented 2 months ago

I kinda have a similar issue with overriding Vencord, whenever I try to open the settings page it crashes with the following:

This is caused by a breaking change from upstream Discord — see Vendicated/Vencord#2584. This issue should be reserved for Nix-specific problems only.

Also, @kutu-dev has the issue ever been fixed on your end? If so, I think this issue could be closed

No luck so far installing the package through Home Manager using the nixpkgs master branch.

NixOS / nixpkgs