metasploit: does not build on aarch64-darwin, x86_64-darwin

rwese commented 3 months ago

Steps To Reproduce

Steps to reproduce the behavior:

on aarch64-darwin, build metasploit nix --extra-experimental-features ca-derivations --option experimental-features 'nix-command flakes fetch-closure' build --impure --no-link 'github:NixOS/nixpkgs/a3ed7406349a9335cb4c2a71369b697cecd9d351#metasploit'

Build log

Last Metasploit version bump build: https://github.com/NixOS/nixpkgs/pull/321442/checks?check_run_id=26541367218 Buildlogs on ofborg

Local build on aarch64

       last 10 log lines:
       > /nix/store/79bxm06zjx3g4wvn876pvxblgjc91vl3-libxml2-2.12.5-dev/include/libxml2/libxml/xmlerror.h:898:29: note: passing argument to parameter 'handler' here
       >                                  xmlStructuredErrorFunc handler);
       >                                                         ^
       > 2 errors generated.
       > make: *** [Makefile:247: html4_document.o] Error 1
       >
       > make failed, exit code 2
       >
       > Gem files will remain installed in /nix/store/7h3lp3xbcddhcnlc2whb02hag0y3fiai-ruby3.1-nokogiri-1.14.5/lib/ruby/gems/3.1.0/gems/nokogiri-1.14.5 for inspection.
       > Results logged to /nix/store/7h3lp3xbcddhcnlc2whb02hag0y3fiai-ruby3.1-nokogiri-1.14.5/lib/ruby/gems/3.1.0/extensions/arm64-darwin-22/3.1.0/nokogiri-1.14.5/gem_make.out

Notify maintainers

@fabaff @makefu

Metadata

 nix-shell -p nix-info --run "nix-info -m"
these 2 paths will be fetched (0.01 MiB download, 0.11 MiB unpacked):
  /nix/store/hiw03p9ijvqkj8qrh5ghh4fmjs6i1m90-DarwinTools-1
  /nix/store/51812lyfvpzqg4fq95mmbsaqzkm6hqhq-nix-info
copying path '/nix/store/hiw03p9ijvqkj8qrh5ghh4fmjs6i1m90-DarwinTools-1' from 'https://cache.nixos.org'...
copying path '/nix/store/51812lyfvpzqg4fq95mmbsaqzkm6hqhq-nix-info' from 'https://cache.nixos.org'...
 - system: `"aarch64-darwin"`
 - host os: `Darwin 23.5.0, macOS 14.5`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.18.1`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Add a :+1: reaction to issues you find important.

rwese commented 3 months ago

forgot to ping @fabaff @makefu

The maintainer info in default.nix points to @fab maybe this should be corrected.

makefu commented 3 months ago

unfortunately i cannot help much here as i do not sport the respective platform. Maybe one of the darwin mantainers can support?

rwese commented 3 months ago

I will try to fix it, but am not yet to versed in the nix build process.

matteo-pacini commented 3 months ago

https://github.com/sparklemotion/nokogiri/issues/3071#issuecomment-1868584945

Looks like Nokogiri can't compile its native code because of our outdated libxml2.

It might start working again after #319982 is in.

fabaff commented 3 months ago

The maintainer info in default.nix points to @fab maybe this should be corrected.

It should not as my entry contain the correct link between username and GitHub handle.

I don't own a darwin box and the community builder for darwin is kind of limited for larger debugging tasks. This mean that support for darwin depends on contributions.

rwese commented 3 months ago

[sparklemotion/nokogiri#3071 (comment)](https://github.com/sparklemotion/nokogiri/ It might start working again after #319982 is in.

It seems also to be here: #321431 where it will be marked as broken.

NixOS / nixpkgs