search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.6k stars 13.07k forks source link

minimal iso does not include git #325170

Open iynaix opened 1 week ago

iynaix commented 1 week ago

Describe the bug

The nixos minimal iso doesn't include git, which causes nixos-install to fail when fetching a remote flake source or any fetchgit calls within a configuration.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Boot minimal installation media
  2. Proceed with standard installation steps until nixos-install
  3. nixos-install --flake github:user/repo#host fails

Expected behavior

git should be included in the minimal iso. For a distro that prides itself on being reproducible from text files, it feels like unnecessary friction having to nix-shell for something as basic and ubiquitous as git.

Additional context

This has been brought up before in #78127, but was rejected after a discussion in nixos-dev. Maybe it's time to revisit this decision?

Notify maintainers

N/A

Add a :+1: reaction to issues you find important.

iblech commented 1 week ago

To inform our decision, our git package is reproducible, so adding git to the minimal iso wouldn't render the iso less reproducible.

bjornfor commented 1 week ago

Steps to reproduce the behavior:

  1. Boot minimal installation media
  2. Proceed with standard installation steps until nixos-install
  3. nixos-install --flake github:user/repo#host fails

Does the minimal iso enable Flakes? I would have expected that command to error out, and hint that Flakes is an experimental feature.

iynaix commented 1 week ago

nixos-install works with flakes out of the box, nothing else does. I'm not really sure why, but I ain't complaining :P