search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.29k stars 14.27k forks source link

Update request: clickhouse v24.3.2.23 → v24.6.2.17-stable #327700

Open jpds opened 4 months ago

jpds commented 4 months ago

The clickhouse package currently in nixpkgs tracks an old LTS version.

This package needs to be updated to default install the latest stable version, as this is recommended by upstream: https://clickhouse.com/docs/en/faq/operations/production - we also then need to provide users with a clickhouse_lts package.

Notify maintainers

@mbalatsko @orivej

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

mbalatsko commented 4 months ago

I've upgraded clickhouse to the latest LTS. I'm a little bit concerned about having stable version as clickhouse package, I'd suggest making it the other way around. clickhouse == lts, and clickhouse-stable == latest stable

mbalatsko commented 4 months ago

Adding latest stable would require a lot more work, I'll try to find capacity on it, but no promises

hkrutzer commented 3 months ago

24.8 is now the latest LTS

jpds commented 2 months ago

I have a work-in-progress branch now at: https://github.com/NixOS/nixpkgs/compare/master...jpds:nixpkgs:clickhouse-24.8.4.13-lts+24.7.6.8-stable

The Rust component currently fails with:

[5993/13663] cd /build/source/build/rust/workspace/prql && /nix/store/hx89vlv61l4vm0dvn0zww817nckzh7ls-cmake-3.29.6/bin/cmake -E env CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CC_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CXX_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang++ AR_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/ar CORROSION_BUILD_DIR=/build/source/build/rust/workspace CARGO_BUILD_RUSTC=/nix/store/g1rc6b7ab28h1sga2kvxfiwp6dqblgzg-rustc-wrapper-1.80.1/bin/rustc /nix/store/8k428qrvnnfg91v6qcvkjm5dpgrgig49-cargo-1.80.1/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package _ch_rust_prql --manifest-path /build/source/build/rust/workspace/prql/Cargo.toml --target-dir /build/source/build/./cargo/build --profile=release-thinlto --offline --locked -- -Cdefault-linker-libraries=no
warning: `/build/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
error: source `https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104` defines source https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104, but that source is already defined by `git+https://github.com/azat-rust/tuikit.git?rev=e1994c0e03ff02c49cf1471f0cc3cbf185ce0104`
note: Sources are not allowed to be defined multiple times.
FAILED: rust/workspace/CMakeFiles/_cargo-build__ch_rust_prql /build/source/build/rust/workspace/CMakeFiles/_cargo-build__ch_rust_prql
cd /build/source/build/rust/workspace/prql && /nix/store/hx89vlv61l4vm0dvn0zww817nckzh7ls-cmake-3.29.6/bin/cmake -E env CARGO_TARGET_X86_64_UNKNOWN_LINUX_GNU_LINKER=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CC_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang CXX_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/clang++ AR_x86_64_unknown_linux_gnu=/nix/store/ilqwhw4wa7xn7w3fiqmacvpxsac7zb3l-clang-wrapper-17.0.6/bin/ar CORROSION_BUILD_DIR=/build/source/build/rust/workspace CARGO_BUILD_RUSTC=/nix/store/g1rc6b7ab28h1sga2kvxfiwp6dqblgzg-rustc-wrapper-1.80.1/bin/rustc /nix/store/8k428qrvnnfg91v6qcvkjm5dpgrgig49-cargo-1.80.1/bin/cargo rustc --lib --target=x86_64-unknown-linux-gnu --package _ch_rust_prql --manifest-path /build/source/build/rust/workspace/prql/Cargo.toml --target-dir /build/source/build/./cargo/build --profile=release-thinlto --offline --locked -- -Cdefault-linker-libraries=no

With rustSupport set to false it compiles just fine. And at some point I want to combine the two edition files into one like nginx/postgresql does.