`services.meilisearch` doesn't respect `system.stateVersion`

sodiboo commented 3 months ago

Describe the bug

Meilisearch fails to start after https://github.com/NixOS/nixpkgs/pull/325354 was merged. It gives me the following error upon a rebuild

Error: Your database version (1.8.3) is incompatible with your current engine version (1.9.0). To migrate data between Meilisearch versions, please follow our guide on https://www.meilisearch.com/docs/learn/update_and_migration/updating.

Steps To Reproduce

Steps to reproduce the behavior:

Set services.meilisearch.enable = true one week ago, e.g. prior to https://github.com/NixOS/nixpkgs/pull/325354 being merged, and populate its database. This uses meilisearch-1.8.3
Switch to an up-to-date nixos-unstable, This uses meilisearch-1.9.0
Rebuild your system.
Observe that Meilisearch fails to start.

Expected behavior

A clear and concise description of what you expected to happen.

I expect it to either use an old version of the meilisearch package, according to system.stateVersion such that the database is still compatible, or to otherwise migrate it automatically such that there is no issue (similar to what i do with my own sharkey package)

Screenshots

If applicable, add screenshots to help explain your problem.

An screenshot of the activation output, showing that it's stopping meilisearch.service, doing various other things, then starting meilisearch.service. Starting it fails for the reason given above.

Additional context

Add any other context about the problem here.

I maintain a private sharkey instance. As part of this, i use the services.meilisearch module. It doesn't do much fancy. I've simply enabled meilisearch, and it complained after a recent system update.
My system has had system.stateVersion = "23.11"; since far before i ever touched the Meilisearch module

Notify maintainers

@Br1ght0ne and @happysalada are the maintainers for the meilisearch module.

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

oxygen ~ $ nix-shell -p nix-info --run "nix-info -m"

 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.37, NixOS, 24.11 (Vicuna), 24.11.20240714.693bc46`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - channels(root): `"nixos"`
 - nixpkgs: `/nix/store/iqxdbcjlg9wx8gdc8bdhy9nsd5imcbjp-source`

Add a :+1: reaction to issues you find important.

happysalada commented 3 months ago

This should definitely be improved. I think to be honest, meilisearch is creating problems in the first place by making all minor versions not compatible with each other. However we could improve upon that, no one had the time to do that yet. If you had time to make that improvement , merging should come relatively fast.

sodiboo commented 3 months ago

For now, to workaround this, I'm just pinning meilisearch to 1.8.3 on my system until a real fix is implemented

NixOS / nixpkgs