NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.97k stars 13.98k forks source link

Build failure: python3Packages.momepy #329363

Closed autra closed 3 months ago

autra commented 3 months ago

Steps To Reproduce

Steps to reproduce the behavior:

  1. build with nix-build -I nixpkgs=. -A python311Packages.momepy

Build log

One test is failing: only the relevant part


=================================== FAILURES ===================================
_______________________ TestDistribution.test_Alignment ________________________

self = <momepy.tests.test_distribution.TestDistribution object at 0x7ffee7ff0c10>

    def test_Alignment(self):
        self.df_buildings["orient"] = mm.Orientation(self.df_buildings).series
        sw = Queen.from_dataframe(self.df_tessellation, ids="uID")
        self.df_buildings["align_sw"] = mm.Alignment(
            self.df_buildings, sw, "uID", self.df_buildings["orient"]
        ).series
        test_value = (
            22.744936872392813
            if Version(shapely.geos_version_string) < Version("3.12")
            else 18.29842494
        )
>       assert self.df_buildings["align_sw"][0] == pytest.approx(test_value)
E       assert 18.299481293674084 == 18.29842494 ± 1.8e-05
E
E         comparison failed
E         Obtained: 18.299481293674084
E         Expected: 18.29842494 ± 1.8e-05

momepy/tests/test_distribution.py:130: AssertionError

Additional context

Add any other context about the problem here.

Notify maintainers

(note, I've set the project to the geospatial team, which should be enough to have it in the radar maybe?)

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.37, NixOS, 24.05 (Uakari), 24.05.20240709.249fbde`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.4`

Add a :+1: reaction to issues you find important.

autra commented 3 months ago

I'm currently bisecting to confirm my intuition that it is a dependency version change that is triggering this failure.

autra commented 3 months ago

The first bad commit could be any of: 234f48f8ee848092e34cad3c8cba3688b51a3782 f4e79757df1a0822d41504e504857bb3e3548d90 79fb496d23c6049b1de2ad4adfa60911986ef00e

Probably an upstream issue?