NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.38k stars 13.61k forks source link

Build failure: vimPlugins.nvim-treesitter.tests.check-queries #333372

Open GaetanLepage opened 1 month ago

GaetanLepage commented 1 month ago

Steps To Reproduce

Steps to reproduce the behavior:

  1. build vimPlugins.nvim-treesitter.tests.check-queries

Build log


Check failed!
Errors:
) Invalid capture @OrgStars1 in highlights for org.
(x) Invalid capture @OrgHeadlineLevel1 in highlights for org.
(x) Invalid capture @OrgStars2 in highlights for org.
(x) Invalid capture @OrgHeadlineLevel2 in highlights for org.
(x) Invalid capture @OrgStars3 in highlights for org.
(x) Invalid capture @OrgHeadlineLevel3 in highlights for org.
(x) Invalid capture @OrgKeywordTodo in highlights for org.
(x) Invalid capture @OrgKeywordDone in highlights for org.
(x) Invalid capture @OrgPriority in highlights for org.
(x) Invalid capture @OrgPriorityCookie in highlights for org.
(x) Invalid capture @OrgTag in highlights for org.
(x) Invalid capture @OrgTagList in highlights for org.
(x) Invalid capture @OrgPropertyDrawer in highlights for org.
(x) Invalid capture @OrgPropertyName in highlights for org.
(x) Invalid capture @OrgPropertyValue in highlights for org.
(x) Invalid capture @OrgProperty in highlights for org.
(x) Invalid capture @OrgTimestampInactive in highlights for org.
(x) Invalid capture @OrgTimestampDay in highlights for org.
(x) Invalid capture @OrgTimestampDate in highlights for org.
(x) Invalid capture @OrgTimestampTime in highlights for org.
(x) Invalid capture @OrgTimestampRepeat in highlights for org.
(x) Invalid capture @OrgTimestampDelay in highlights for org.
(x) Invalid capture @OrgTimestampActive in highlights for org.
(x) Invalid capture @OrgFootnoteLabel in highlights for org.
(x) Invalid capture @OrgFootnoteDescription in highlights for org.
(x) Invalid capture @OrgFootnoteDefinition in highlights for org.
(x) Invalid capture @OrgDirectiveName in highlights for org.
(x) Invalid capture @OrgDirectiveValue in highlights for org.
(x) Invalid capture @OrgDirective in highlights for org.
(x) Invalid capture @OrgComment in highlights for org.
(x) Invalid capture @OrgDrawerName in highlights for org.
(x) Invalid capture @OrgDrawerContents in highlights for org.
(x) Invalid capture @OrgDrawer in highlights for org.
(x) Invalid capture @OrgBlockName in highlights for org.
(x) Invalid capture @OrgBlockContents in highlights for org.
(x) Invalid capture @OrgBlock in highlights for org.
(x) Invalid capture @OrgDynamicBlockName in highlights for org.
(x) Invalid capture @OrgDynamicBlockContents in highlights for org.
(x) Invalid capture @OrgDynamicBlock in highlights for org.
(x) Invalid capture @OrgListBullet in highlights for org.
(x) Invalid capture @OrgCheckbox in highlights for org.
(x) Invalid capture @OrgCheckInProgress in highlights for org.
(x) Invalid capture @OrgCheckDone in highlights for org.
(x) Invalid capture @Error in highlights for org.
(x) Invalid capture @OrgTableHorizontalRuler in highlights for org.
(x) Invalid capture @OrgCellFormula in highlights for org.
(x) Invalid capture @OrgCellNumber in highlights for org.
(x) Invalid capture @property in locals for qmljs.
(x) Invalid capture @reference._let in locals for racket.
(x) Invalid capture @reference._def in locals for racket.

Additional context

Add any other context about the problem here.

Notify maintainers

Maintainer: cc @figsoda Other relevant contributors: cc @teto @mrcjkb

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.43, NixOS, 24.11 (Vicuna), 24.11.20240804.cb9a96f`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/4cpakzyvfw1rmm9v5i3387x6jd2h1v86-source`

Add a :+1: reaction to issues you find important.

mrcjkb commented 1 month ago

:thinking: nvim-treesitter no longer bundles any queries for tree-sitter-org. So I wonder where they're coming from (if not from an older version of nvim-treesitter).

BirdeeHub commented 2 weeks ago

now its bundling ALL the grammars into a single vimplugin-treesitter-grammars DRV, and another one of my plugins is somehow adding in duplicates causing a collision and I cannot figure out why, or what changed....

If I build a neovim with JUST nvim-treesitter.withAllGrammars it builds, and groups them all into a vimplugin-treesitter-grammars drv which it did not before, it used to just put them all in the packpath as their own plugin.

If I try to build my config, something is adding more stuff in there to it and its conflicting, all I get is a single line saying it cant use ln because the parser exists already... doing a trace shows several duplicates. And none of the duplicates are from the builtin ones....

its not the norg overlay I tried disabling that...

Pretty confused rn

Any chance this is a related issue or should I be opening a new one?

BirdeeHub commented 2 weeks ago

Also, judging by the issues threads about grammars,

Does anyone ACTUALLY know how the queries were being included before being copied as described in this issue?

If not we NEED to figure that out before continuing fixing them

If anyone does, PLEASE let me know. Ive tried but I dont have the pre existing knowledge about grammars to figure it out yet I think

BirdeeHub commented 1 week ago

https://github.com/NixOS/nixpkgs/pull/339076?notification_referrer_id=NT_kwDOBRauArQxMjIxOTk5ODQ4NDo4NTM3MjQxOA#issuecomment-2327676324

The collisions I mentioned were this issue

PerchunPak commented 2 days ago

Collisions in treesitter grammars are impossible, as treesitter chooses the first grammar it finds, and ignores others (to allow plugins overwrite built-in grammars).

Though bisected this to 51e69413cfc928d02e19c27c9342af2931166d4d, maybe that's also an upstream bug?