search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.38k stars 13.61k forks source link

Update request: clolcat 1.1 → lolcat-c 1.5 #333577

Open SpidFightFR opened 1 month ago

SpidFightFR commented 1 month ago

Notify maintainers Hey @felipeqq2 :wave:

Note for maintainers: Please tag this issue in your PR.

Note regarding this issue: I recommend switching from clolcat to lolcat(-c) as the later one is still updated as of today, in comparison of the first one that saw it's last update in 2021. Thus, the new one fixes a lot of issues, notably, an issue when fastfetch is thrown into lolcat-c. This update shouldn't be hard to make. As for the name perhaps it should be better to change it, or make a new package altogether ?

Add a :+1: reaction to issues you find important.

felipeqq2 commented 1 month ago

Hey @SpidFightFR! As this is a different package, I don't think it's appropriate to just update clolcat to lolcat-c. We can add a new package (as noted in your comment), and possibly remove clolcat.

Please note that:

  1. There is an open PR to add lolcat-c to nixpkgs (#225482).
  2. There were some discussions on the existence of multiple lolcats (https://github.com/NixOS/nixpkgs/issues/258479#issuecomment-1742486263).
felipeqq2 commented 1 month ago

Is the issue with fastfetch present in clolcat, or just oldest versions of lolcat-c?

SpidFightFR commented 1 month ago

Hey @SpidFightFR! As this is a different package, I don't think it's appropriate to just update clolcat to lolcat-c. We can add a new package (as noted in your comment), and possibly remove clolcat.

Please note that:

  1. There is an open PR to add lolcat-c to nixpkgs (#225482).
  2. There were some discussions on the existence of multiple lolcats (https://github.com/NixOS/nixpkgs/issues/258479#issuecomment-1742486263).

Hey thanks for your answer, and the links!

I subbed to the first pr, although it seems stalled... Should i close this issue in the meantime?