search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.08k stars 14.06k forks source link

dmenu-rs: Activate all mainline plugins #333733

Open jceb opened 2 months ago

jceb commented 2 months ago

Thank you @benjaminedwardwebb for packaging dmenu-rs, I'm looking forward to replacing my hand-rolled dmenu with it :+1: I noticed that it's tricky to enable plugins via the nixos configuration. What do you think about activating all mainline plugins by default or ship a dmenu-rs-full package? The key plugin I'm missing is the fuzzy finder.

Steps To Reproduce

  1. install dmenu-rs
  2. struggle to customize

Expected behavior

  1. install dmenu-rs
  2. be able to use all mainline plugins

Notify maintainers

@benjaminedwardwebb

benjaminedwardwebb commented 2 months ago

Hey @jceb, I think a dmenu-rs-full package is a great idea!

When originally adding the package I wanted to make plugins configurable through override flags, but at the time I couldn't figure out how to do that and so left it for later. An alternative, plugin-enabled package sounds like it might be easier.

Were you able to get an overlay or something similar working locally that layers on plugins?

benjaminedwardwebb commented 2 months ago

I have a sketch of the idea available here https://github.com/NixOS/nixpkgs/pull/333837

I haven't tested it off of a branch of nixpkgs yet. You may be able to copy the gist of it locally into an overlay to test it (or solve the issue for yourself) -- if you do try this, please let me know if it does or doesn't work. And keep the issue open even if it does solve it for you.

I'm not sure when the PR will actually merge, as I'll need to do additional testing and make sure I'm following the appropriate nixpkgs conventions and then get the attention of typically busy reviewers. Also FYI that the next release is November. But until then, there are overlays. :)

jceb commented 2 months ago

Were you able to get an overlay or something similar working locally that layers on plugins?

No, I failed to get things to work due to some weird compile errors that I couldn't figure out 🤦‍♂️

jceb commented 2 months ago

I'll give it a shot and thank you for the quick response 😃

benjaminedwardwebb commented 3 days ago

@jceb a new package, dmenu-rs-enable-plugins, should be available in NixOS 24.11 when it's released in about a month.

This was the PR that added it: https://github.com/NixOS/nixpkgs/pull/333837

I hope you enjoy the plugins.