github-desktop: cannot find vscode installation

[UlyssesZh]

Describe the bug

I installed github-desktop from 24.05 branch and vscode-with-extensions from master branch. GitHub Desktop cannot find my VSCode installation in the integration settings.

Steps To Reproduce

Steps to reproduce the behavior:

1. Install github-desktop and vscode-with-extensions.
2. Launch GitHub Desktop and open integration settings.
3. See that there are not editors found.

Expected behavior

Having integration between GitHub Desktop and VSCode.

Screenshots

Additional context

Notify maintainers

@dan4ik605743

Metadata

• system: "x86_64-linux"
• host os: Linux 6.1.103, NixOS, 24.05 (Uakari), 24.05.3787.a781ff33ae25
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.18.5
• channels(root): "nixos-24.05, nixos-hardware, nixos-unstable"
• nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

---

Add a :+1: reaction to issues you find important.

[s0me1newithhand7s]

can you try nix-shell -p vscode github-desktop? (if gui works under nix-shell :D)

[UlyssesZh]

Doesn't seem to work.

[s0me1newithhand7s]

Doesn't seem to work.

'k, i'll try it myself.. asap.

[s0me1newithhand7s]

i cannot reproduce it, strange..

[UlyssesZh]

https://github.com/shiftkey/desktop/blob/3d20d0dc269186e067f1846cb3df1eed314f66d4/app/src/lib/editors/linux.ts#L41-L48

It seems to find editors in hard-coded paths? This should not find installations in /nix/store then.

[s0me1newithhand7s]

https://github.com/shiftkey/desktop/blob/3d20d0dc269186e067f1846cb3df1eed314f66d4/app/src/lib/editors/linux.ts#L41-L48

It seems to find editors in hard-coded paths? This should not find installations in /nix/store then.

yep, maybe a PR with Nixified path will help?

[s0me1newithhand7s]

https://github.com/shiftkey/desktop/pull/1115

'k