Regression: Brave browser is now missing IPFS integration

Describe the bug

Brave browser lacks its built-in IPFS integration on recent builds.

This version of NixPKGs from 2 months ago has IPFS support: 5263155d866fb906de9ae157dd118322e6bbf21b 2024-06-12T20:27:20Z

This version of NixPKGs from yesterday does not have IPFS support: 192bd3730c7890fb4b3b427cf88acce47824fcf3 2024-08-25T11:55:08Z

Steps To Reproduce

Steps to reproduce the behavior:

Start brave from the command-line
Navigate to brave://ipfs (redirects to brave://ipfs-internals)
Error: "This site can’t be reached"

Alternative steps to reproduce:

Start brave from the command-line
Navigate to ipns://ipfs.tech/
Browser asks to open URL with xdg-open

Expected behavior

The brave://ipfs page should be an internal IPFS status page.

The ipns://ipfs.tech/ page should load the page over IPFS (if needed automatically asking to enable IPFS).

Screenshots

Incorrect behaviour (2024-08-25 version):

brave://ipfs not loading brave://ipfs-internals not loading ipns://ipfs.tech/ trying to open using external xdg-open

Expected behaviour (2024-06-12 version): brave://ipfs-internals shows status ipns://ipfs.tech/ shows the page loaded over IPFS

Additional context

I'm using NixPKGs (a nix flake with all my installed packages, built with nix build path:///home/me/flake/ --out-link /home/me/flake/result; PATH="/home/me/flake/result/bin:$PATH") on top of Linux Mint. This setup has not changed between the working and faulty versions.

When starting the new version, and then starting again the old version, the old version seems to have "forgotten" that IPFS was enabled, and asks to enable it again. It seems that the new version simply was compiled without IPFS support somehow, and erases that part of the settings.

Notify maintainers

@uskudnik @rht @JeffLabonte @nasirhm @buckley310

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-info -m
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.0-119-generic, Linux Mint, 21.3 (Virginia), nobuild`
 - multi-user?: `no`
 - sandbox: `yes`
 - version: `nix-env (Nix) 3.0pre20200829_f156513`
 - channels(root): `"nixpkgs"`
 - nixpkgs: `not found`

Note: I build from a flake, instead of having a system-wide channel, which explains the nixpkgs: not found on my system.

Add a :+1: reaction to issues you find important.

NixOS / nixpkgs