NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.75k stars 13.86k forks source link

apache solr: CVE-2017-12629 & CVE-2017-3163 #33876

Closed andir closed 5 years ago

andir commented 6 years ago

Issue description

There are at least two potential long-term security issues with the solr version in 17.09 (and potentially unstable):

CC maintainers of solr: @rickynils @domenkozar

From what I can see with a simple search through nixpkgs the following packages are also potentially affected by this (since they ship their own copy of solr):

andir commented 6 years ago

another attempt at this.. If no maintainer shows interest in at least upgrading those packages we should remove them.

@cstrahan @mdaiter @rickynils @domenkozar

mdaiter commented 6 years ago

@andir thanks for pinging. I'll upgrade riak to 2.2.3. Sadly, we've got to ship with our own version: Riak requires a specific basho-linked version of solr.

mdaiter commented 6 years ago

@andir sadly, don't have access to a Linux machine atm but here's a preliminary patch: https://github.com/mdaiter/nixpkgs/commit/a61893f5a34317fc652c37f4878dda66a7655cbf

andir commented 6 years ago

@mdaiter Thank you for working on this!

Do you have references to the release notes of solr/riak in respect to those issues I linked initially? I fail to make any sense of the changelogs in regards to the mentioned issues. That might just be me being confused by all the riak versions on their website. :/

mdaiter commented 6 years ago

@andir , sadly I have none :(

aanderse commented 5 years ago

@mdaiter @andir If either of you are familiar with solr I would appreciate some feedback and maybe testing regarding PR https://github.com/NixOS/nixpkgs/pull/49283.

Thanks

andir commented 5 years ago

@aanderse I am not familiar with the software. I will have a look anyway :)

andir commented 5 years ago

Thanks to @aanderse there solr issue is resolved as of now (on master).

So this still leaves the question of riak distributing their own (broken?) copy. Anyone familiar with it?

c0bw3b commented 5 years ago

Im' not familiar with this software but after some research I see that Riak 2.2.0+ search module (named Yokozuna) ships Solr 4.10.4 See: https://github.com/NixOS/nixpkgs/blob/b352d47e42b5babe82d937b2d5c77476b663dd88/pkgs/servers/nosql/riak/2.2.0.nix#L4 and https://github.com/basho/yokozuna/blob/develop-2.2/tools/grab-solr.sh#L21



Closing then?

andir commented 5 years ago

Yeah, it is a bit sad but let's close it. Should we mark riak as insecure then?

On Mon, 10 Dec 2018, 14:55 Renaud, notifications@github.com wrote:

Im' not familiar with this software but after some research I see that Riak 2.2.0+ search module (named Yokozuna) ships Solr 4.10.4 See:

https://github.com/NixOS/nixpkgs/blob/b352d47e42b5babe82d937b2d5c77476b663dd88/pkgs/servers/nosql/riak/2.2.0.nix#L4 and https://github.com/basho/yokozuna/blob/develop-2.2/tools/grab-solr.sh#L21

Closing then?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/issues/33876#issuecomment-445823124, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm_dCOHW5YeHkr7BGIoFd9_v9YU6pPzks5u3mfugaJpZM4Rd005 .

c0bw3b commented 5 years ago

I don't know if it let Solr API exposed or not though. If Riak search is exposed only to authenticated users on Riak admin backend then the exploit would be possible only for already-privileged users.

@cstrahan @mdaiter any idea here? (as riak maintainers)

aanderse commented 5 years ago

@andir no reply so let's mark riak as insecure and close this?

aanderse commented 5 years ago

Also related... https://github.com/NixOS/nixpkgs/issues/56294

mdaiter commented 5 years ago

@c0bw3b and @aanderse sorry for being a bit AWOL!

I think Riak and Riak-CS have stopped being maintained by Basho (hasn't been a single release since 2017 for riak-core) -- and I'd mark both as insecure.