search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.07k stars 14.06k forks source link

invalid generated fonts.conf #338908

Closed yshui closed 2 months ago

yshui commented 2 months ago

Describe the bug

49d33d4a6b15330b492a194edc4b67fb20a15fa1

this sed command is not escaped properly

sed "5i <include ignore_missing="yes">/etc/fonts/conf.d</include>" -i $dst/../fonts.conf

which generates a line like this:

<include ignore_missing=yes>/etc/fonts/conf.d</include>

which is missing double quotes around yes

Notify maintainers

@K900

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
output here

Add a :+1: reaction to issues you find important.

yshui commented 2 months ago

error reported by fontconfig:

Fontconfig error: "/etc/fonts/fonts.conf", line 5: not well-formed (invalid token)
Fontconfig error: Cannot load config file from /etc/fonts/fonts.conf
griffi-gh commented 2 months ago

Can confirm, getting the same issue.

image image

griffi-gh commented 2 months ago

also broke my fonts in most of my applications

eclairevoyant commented 2 months ago

fixed in b5574c71bec95159d5342c19f6d5221b68c2aaee (#338815)

yshui commented 2 months ago

even with this problem fixed my fonts are still messed up...

zoechi commented 2 months ago

@eclairevoyant might be #338933