NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.1k stars 14.15k forks source link

Update request: rqbit 6.0.0 → 7.0.1 #339231

Closed ToasterUwU closed 6 days ago

ToasterUwU commented 2 months ago

Notify maintainers @cafkafk


Note for maintainers: Please tag this issue in your PR.


Add a :+1: reaction to issues you find important.

ToasterUwU commented 2 months ago

The reason im not just updating this myself, which i could since im a maintainer, is that there is something new in the builld process that throws me for a loop.

Specifically, 7.0.0 added a UPNP Server which needs nodejs and typescript to present to build the Rust Crate. So we need to change the package.nix in a way where the rust build can build a npm package within itself. And im just too new to Nix to understand what to do.

I got as far as adding nodejs and typescript to the native build inputs, but when i build it after that i get a bunch of TS errors:

       >   error TS2688: Cannot find type definition file for 'react-dom'.
       >     The file is in the program because:
       >       Entry point for implicit type library 'react-dom'
       >   error TS2688: Cannot find type definition file for 'warning'.
       >     The file is in the program because:
       >       Entry point for implicit type library 'warning'
ToasterUwU commented 2 months ago

@cafkafk if you have any ideas, let me know and i can try them. Otherwise feel free to make a PR yourself and ping me to review it.

ToasterUwU commented 2 months ago

Ok, i checked and it requires to go into the subfolder thats needed, than use npm install, before running the actual build command.. I have no idea how to realize that in Nix.

Daru-san commented 2 weeks ago

I am trying to update via pr #350989. Still in progress but getting somewhere.