search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.42k stars 13.63k forks source link

wechat-uos: OpenSSL 1.1 is end of life #340954

Closed kaleocheng closed 4 days ago

kaleocheng commented 1 week ago

the package wechat uos is still using OpenSSL 1.1 https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/we/wechat-uos/package.nix#L176 which is end of life on 2023/09/11, so it is marked as insecure now.

not sure if we need to wait for wechat-uos or we can just bump it up in here.

@pokon548 @xddxdd

Add a :+1: reaction to issues you find important.

pokon548 commented 1 week ago

not sure if we need to wait for wechat-uos or we can just bump it up in here.

As far as I know, only libuosdevicea.so from https://github.com/NixOS/nixpkgs/blob/07a86f74421333e7fd379fbce416bf982523887e/pkgs/by-name/we/wechat-uos/package.nix#L240C53-L240C69 depends on OpenSSL 1.1. Seems like we may replace it with stub implementation to completely remove openssl_1_1 dependency.

I will try to fix that in the next PR when I have free time.

Cryolitia commented 5 days ago

Would it be offensive if I could submit a patch about it now.

pokon548 commented 5 days ago

Would it be offensive if I could submit a patch about it now.

Feel free to do so. I would be happy to review your pr :)