NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.58k stars 13.73k forks source link

VSCode description is misleading #342046

Open moonlitpath opened 2 weeks ago

moonlitpath commented 2 weeks ago

Describe the bug

Even though VSCode is built on open source, the app itself is not open.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Disable non-free software
  2. Try to install VSCode

Expected behavior

The term "open source" shouldn't be used in the app's description.

Screenshots

image

Notify maintainers

@eadwu @synthetica @bobby285271 @Enzime


Add a :+1: reaction to issues you find important.

ahydronous commented 6 days ago

You are confusing OSS and FOSS.

Something can be open source but unfree, meaning you can inspect and modify the source code, but you aren't allowed to just do with it whatever you want.

If VSCode wasn't open source, you wouldn't have the multitude of forks that exist.

moonlitpath commented 5 days ago

Something can be open source but unfree, meaning you can inspect and modify the source code, but you aren't allowed to just do with it whatever you want.

You're confusing Open Source and Source-Available. Please read the definition of open source. In the context of this situation, there's no difference between OSS and FOSS/FLOSS, by the way.

If VSCode wasn't open source, you wouldn't have the multitude of forks that exist.

Those are not forks of VSCode, they're forks of Code-OSS. And the reason why they exist is because VSCode is not open.

I understand the confusion. This repo is called vscode, but the actual product in it is called Code-OSS, as you can see in the README. Microsoft uses it to build VSCode.

ahydronous commented 4 days ago

Open source in the general language != open source in the technical definition. But I think no one wins with pedantry, so instead for a solution: we can take a page out of Microsoft’s book, who describe VSCode in part with:

Built on open source

We could edit the VSCode description to be

Source code editor developed by Microsoft for Windows, Linux and MacOS. Built on open source.

if that seems agreeable?

moonlitpath commented 4 days ago

Sounds good to me.