NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.09k stars 14.14k forks source link

aider dependency issue causes crash #342572

Closed alexanderkjeldaas closed 1 month ago

alexanderkjeldaas commented 1 month ago

Describe the bug

A small difference in the dependencies used by aider and nixpkgs causes aider to crash.

Steps To Reproduce

  1. run aider 0.56.0
  2. type something
  3. it should get a stack overflow

See https://github.com/paul-gauthier/aider/issues/1557

@taha-yassine

Metadata

Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.10.6, NixOS, 24.11 (Vicuna), 24.11.20240821.c374d94`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.18.5`
 - nixpkgs: `/nix/store/j8pbrsb3nybdap3hhg9kw0ffqd4rlbx6-source`

Add a :+1: reaction to issues you find important.

alexanderkjeldaas commented 1 month ago

https://github.com/NixOS/nixpkgs/issues/342523 was closed by mistake so opened this

taha-yassine commented 1 month ago

Thanks for opening this issue. Discussion started here https://github.com/NixOS/nixpkgs/pull/341015. It is clear that v1.44.22 of litellmis what causes the issue but I'm not sure what could be done. @happysalada maybe you have an idea?

happysalada commented 1 month ago

There is an open issue in the repo, we have to wait for the dependencies to be updated upstream unfortunately. On the next update of this dependency ill be sure to try to run aider. Sorry for the inconvenience !

dotlambda commented 1 month ago

we have to wait for the dependencies to be updated upstream unfortunately

Why don't you use packageOverrides?

benbot commented 1 month ago

@happysalada the issue on aider's repo was closed https://github.com/paul-gauthier/aider/issues/1278

the fix is to not use the wrong version of litellm :sweat:

benbot commented 1 month ago

we have to wait for the dependencies to be updated upstream unfortunately

Why don't you use packageOverrides?

it's not so simple for python packages. each one is a forest of carefully balanced dependencies.

happysalada commented 1 month ago

Latest aider update matches with the latest litellm update, so we should be good in a couple of days