Remove cruft from platform descriptions

Ericson2314 commented 6 years ago

Simply put, I should be able to do

$ nix-build '<nixpkgs>' --arg crossSystem '{ config = "aarch64-unknown-linux-gnu"; }' -A stdenv

and that should work. I could make it work right now with a dirty white-list and fall-backs, but that's kind of defeats the point.

Currently, the biggest culprits are

Random top-level fields, like withTLS and openssl.system. See https://github.com/NixOS/nixpkgs/blob/master/lib/systems/examples.nix
The platform field, see https://github.com/NixOS/nixpkgs/blob/master/lib/systems/platforms.nix
arch which overlaps with the far more principled parsed,arch. See elaborate https://github.com/NixOS/nixpkgs/blob/master/lib/systems/default.nix#L17.

The general design issue is we need to handle the per-package random crap in a more modular way, without giving up the possibility of the user to override with their own values. My GNU ld emulation picking logic at https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/bintools-wrapper/default.nix#L167-L179 is certainly in a more modular location, but also cannot be nicely overridden.

Checklist

[x] #34303: withTLS
[x] #34315: bigEndian, openssl.system
[x] #34351: linux kernel cleanups
[x] #107214 / #110544: A few cleanups:
- Get rid of nesting items under platforms for no good reason
- group linux config fields rather than merely prefixing them
- improve defaulting logic so config is enough in more cases.
[ ] Combine/rerrange platforms.nix and examples.nix
- We should only default to generic/"multiplatform" settings; specific machines should be specified by hand.
- Specific machines shouldn't be partly in platforms.nix and partly in examples.nix, that is just confusing.
[ ] Update manual to show how indeed the config is usually enough, and remove the reference to this issue.

CC @dtzWill @dezgeg @Infinisil @teto

teto commented 6 years ago

I have a PR in the works (should be ready tomorrow) that allows to do

my_kernel = buildLinux {
kernelAutoModules=true, ignoreConfigErrors=true, kernelPreferBuiltin
}

which makes for a much better experience as it looks more like your typical derivation. I let the parameters kernelAutoModules etc as defaults in the platform sets. Do you suggest I remove these parameters from these platform sets https://github.com/NixOS/nixpkgs/blob/master/lib/systems/platforms.nix#L36 ?

Ericson2314 commented 6 years ago

@teto I'd say only leave things for kernel headers there, as that actually effects everything (on Linux).

dezgeg commented 6 years ago

I agree for refactoring openssl and most of the kernel stuff out, but much of the other stuff seems quite hard to get rid of.

dezgeg commented 6 years ago

I made some WIP stuff for the kernel one time: https://github.com/NixOS/nixpkgs/compare/master...dezgeg:kernel-plat-fix?expand=1, but IIRC some of the kernels failed to boot during runtime, still need to debug that one day.

Ericson2314 commented 6 years ago

Per https://github.com/NixOS/nixpkgs/pull/34645#discussion_r166325878 @dtzWill and I need to figure out whether to moved libc into parsed, or similar. @dezgeg or anyone else have any opinions? https://github.com/NixOS/nixpkgs/pull/34444 is also impacted.

dtzWill commented 6 years ago

For what it's worth, I've started using just the "config" in my cross specifications and so far so good!

I don't cross-build kernels as part of my work or testing, and I note that is the remaining TODO item :). Just wanted to chime in that the rest is in a good place!

Minor convenience thing: it's annoying to specify --arg crossSystem '{ config = "x"; }' instead of something like --argstr crossConfig x, especially as the good work on this issue makes anything other than config unnecessary (at least usually). Is there a simple way we could allow the shorter syntax without compromising abstractions? (similar to how we handle "system" today, minus special nix support)

Ericson2314 commented 6 years ago

@dtzWill Maybe we can get --argstr crossSystem.config to work for 1.12? Though I feel bad asking for new features for that release, I'm hesitant to add any more sugar as the platform stuff is already far too complicated.

made issue: https://github.com/NixOS/nix/issues/1850

dtzWill commented 6 years ago

@Ericson2314 thanks for the issue, and agreed not priority for nix update. I was just wanting to discuss it to see what you had in mind.

I'll follow that issue, neat idea!

I agree we shouldn't further complicate the platform stuff, haha, it's actually partly why I asked O:).

Ericson2314 commented 6 years ago

I made a bunch of changes so this is now true. All the examples contain at most config, platform, and additional platform-specific flags like useIosPrebuilt that are new and don't overlap. Yay!

Profpatsch commented 5 years ago

This is still linked in the manual, should be removed if closed.

stale[bot] commented 4 years ago

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

siraben commented 3 years ago

Still important to me

siraben commented 3 years ago

I can take a look at this once #105364 is merged.

siraben commented 3 years ago

@Ericson2314 @Profpatsch Is this still an issue? Can the reference in the manual be deleted?

Ericson2314 commented 3 years ago

If we can merge https://github.com/NixOS/nixpkgs/pull/107214, and (better still) rearrange examples.nix and platforms.nix into something more sensible afterwords, then I'd say this is done.

Ericson2314 commented 3 years ago

Added the checkboxes for those.

Ericson2314 commented 3 years ago

@siraben OK, just the final coding step (and manual victor lap) remains. If you want to take a stab at this, that would be much appreciated!

sambacha commented 3 months ago

This issue is still referenced in the manual BTW

NixOS / nixpkgs