search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.59k stars 13.74k forks source link

Update request: lsp-plugins 1.2.16 → 1.2.17 #344972

Open soupglasses opened 4 days ago

soupglasses commented 4 days ago

Notify maintainers

@magnetophon @PowerUser64

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

soupglasses commented 4 days ago

Annoyingly it seems that 1.2.17 is only distributed in a .7z now.

This is as far as i got attempting to package this new version:

lsp-plugins = pkgs.lsp-plugins.overrideAttrs (old: rec {
  version = "1.2.17";
  src = builtins.fetchurl {
    url = "https://github.com/lsp-plugins/lsp-plugins/releases/download/${version}/lsp-plugins-src-${version}.7z";
    sha256 = "0wsava0ri061dzf5axjfkfbnhb5qrf5x2v2psipkd0yaqi1gyzgh";
  };
  nativeBuildInputs = (old.nativeBuildInputs or []) ++ [pkgs.p7zip pkgs.gst_all_1.gstreamer.dev pkgs.gst_all_1.gst-plugins-base.dev];
});

Cant get it to go past this build failure, which seems like a Makefile issue upstream?

lsp-plugins> make[4]: Leaving directory '/build/lsp-plugins-src-1.2.17/.build/target/lsp-plugin-fw/gst'
lsp-plugins> Install gst
lsp-plugins> make[4]: Entering directory '/build/lsp-plugins-src-1.2.17/.build/target/lsp-plugin-fw/gst'
lsp-plugins> install: cannot create regular file '/nix/store/sk4q9vfz4mqrjkvdjqzg0nmsz0b3fqyx-gstreamer-1.24.3/lib/gstreamer-1.0/libgstlsp-plugins-ab-tester-x2-mono.so': Permission denied
lsp-plugins> install: cannot create regular file '/nix/store/sk4q9vfz4mqrjkvdjqzg0nmsz0b3fqyx-gstreamer-1.24.3/lib/gstreamer-1.0/libgstlsp-plugins-ab-tester-x2-stereo.so': Permission denied
...
lsp-plugins> install: cannot create regular file '/nix/store/sk4q9vfz4mqrjkvdjqzg0nmsz0b3fqyx-gstreamer-1.24.3/lib/gstreamer-1.0/libgstlsp-plugins-trigger-stereo.so': Permission denied
lsp-plugins> make[4]: *** [Makefile:399: install] Error 1
lsp-plugins> make[4]: Leaving directory '/build/lsp-plugins-src-1.2.17/.build/target/lsp-plugin-fw/gst'
lsp-plugins> make[3]: *** [Makefile:1440: install_gst] Error 2
lsp-plugins> make[3]: *** Waiting for unfinished jobs....
lsp-plugins> make[4]: Leaving directory '/build/lsp-plugins-src-1.2.17/.build/target/lsp-plugin-fw/jack'
lsp-plugins> make[4]: Leaving directory '/build/lsp-plugins-src-1.2.17/.build/target/lsp-plugin-fw/vst2'
lsp-plugins> make[3]: Leaving directory '/build/lsp-plugins-src-1.2.17/modules/lsp-plugin-fw/src'
lsp-plugins> make[2]: *** [Makefile:67: install] Error 2
lsp-plugins> make[2]: Leaving directory '/build/lsp-plugins-src-1.2.17/modules/lsp-plugin-fw'
lsp-plugins> make[1]: *** [Makefile:145: install] Error 2
lsp-plugins> make[1]: Leaving directory '/build/lsp-plugins-src-1.2.17/src'
lsp-plugins> make: *** [Makefile:68: install] Error 2
soupglasses commented 4 days ago

lsp-plugins-1.2.16 and older cause an issue for easyeffects-7.1.9 with its spectrum analyzer. Currently applying a workaround in #344971, but the correct solution would be to update lsp-plugins to the newer version.