NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.12k stars 14.15k forks source link

Package request: Nu Plugins #345441

Open Talia-12 opened 1 month ago

Talia-12 commented 1 month ago

Project description

I have a small collection of nu plugins that I've started packaging, would there be interest in getting them added to the nixpkgs plugins set? Also, I'm not sure whether they'd need to be modified to fit the packaging style of the existing plugins.

Requesting relevant maintainers input: @JoaquinTrinanes, @JohnTitor, @Br1ght0ne, @aidalgol

Metadata


Add a :+1: reaction to issues you find important.

aidalgol commented 1 month ago

The regex plugin should not be re-added until upstream starts putting out releases, or someone maintains a fork that maintains comparability with Nushell releases, rather than always targeting Nushell main. See #294465 for background.

Talia-12 commented 1 month ago

The difference between the version of nu that upstream depends on and 0.97.1 was sufficiently small that updating the toml and lock with nix is all that was required to get it working for me, although if you'd prefer I fork upstream and fix the nushell version in the fork I'm happy to do that

aidalgol commented 1 month ago

Please read the explanation in the PR I referenced. That's what I was doing until a Nushell update broke compatibility. When this happened, the plugin could not be built against the version of Nushell in nixpkgs, even after modifying the Cargo.toml file. We will just run into this again at some point if the plugin is reintroduced.

Talia-12 commented 1 month ago

Yeah, fair enough

Talia-12 commented 1 month ago

hm, it seems like three weeks ago upstream swapped to remove the the dependence on nushells main branch and is instead pointed at 0.97.1/0.98.0. Is a git commit to point the nixpkgs version at sufficient in your view, or is an actual release required?

Talia-12 commented 1 month ago

actually scratch that there is a release on crates.io

aidalgol commented 1 month ago

I'd say that's sufficient grounds to reintroduce to nixpkgs. Maybe open a ticket asking if the author could please tag crates.io releases.