NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18k stars 14.01k forks source link

mimalloc.dev: fails to include mimalloc subdirectory #345498

Open superherointj opened 3 weeks ago

superherointj commented 3 weeks ago

Describe the bug

mimalloc.dev: fails to include mimalloc subdirectory containing: atomic.h, internal.h, prim.h, track.h, types.h

Steps To Reproduce

  1. nix build .#mimalloc.dev
  2. ls ./result-dev/include/mimalloc/

Expected behavior

This should happen:

image

Additional context

Force adding the sub-directory as:

cp -r $src/include/mimalloc $dev/include/mimalloc/

https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/libraries/mimalloc/default.nix#L47

Question: Shouldn't sub-directories be automatically added? (I think, it should, which also means this is a side-effect of somewhere else wrong.)

My guess is sub-directories aren't included here:

https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/setup-hooks/multiple-outputs.sh#L108

Notify maintainers

CC @kamadorueda @thoughtpolice

Artturin commented 3 weeks ago

multiple-outputs.sh moves files already in the output, the issue here is that upstream doesn't even install those files

Check files https://archlinux.org/packages/extra/x86_64/mimalloc/