search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.19k stars 14.19k forks source link

nchat: WhatsApp functionality is being disabled in the build #345884

Open Steinhagen opened 1 month ago

Steinhagen commented 1 month ago

Describe the bug

nchat should be able to support both Telegram and WhatsApp. Currently that's being disabled by our recipe.

  cmakeFlags = [
    "-DHAS_WHATSAPP=OFF" # go module build required
  ];

Add a :+1: reaction to issues you find important.

Frontear commented 1 month ago

Please ping the maintainer as this was obviously a deliberate decision. Would be nice to know why this was the case

hacscred commented 1 month ago

The maintainer wanted to scratch their itch and wanted to contribute to nixpkgs, probably.

It's likely that some dependency wasn't packaged already in nixpkgs, so the maintainer just made something work.

No need to bother the maintainer for that.

Best way forward is, if the person with the request makes a serious attempt at making the changes. The documentation is all there to do so.