Update request: lenovo-legion 0.0.12 → current master

NixOS / nixpkgs

Nix Packages collection & NixOS

MIT License

17.79k stars 13.9k forks source link

Open CHN-beta opened 3 days ago

CHN-beta commented 3 days ago

Package name: lenovo-legion-app & lenovo-legion-module
Latest released version: 0.0.18, but a patch in master is needed for kernel 6.11
Current version on the unstable channel: 0.0.12
Current version on the stable/release channel: 0.0.12
[x] Checked the nixpkgs pull requests

Notify maintainers

@ulrikstrid

CHN-beta commented 3 days ago

Simply updating src does not work, substituteInPlace in postPatch will fail.

i-am-logger commented 2 days ago

i'll try to work on it... the v0.0.18 isn't a release yet, its a tag though

i started to experience with kernel 6.11 ```/build/source/kernel_module/legion-laptop.c:6058:19: error: initialization of 'void ()(struct platform_device )' from incompatible pointer type 'int ()(struct platform_device )' [8;;https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wincompatible-pointer-types-Werror=incompatible-pointer-types8;;]

6058 | .remove = legion_remove,```

i-am-logger commented 2 days ago

CHN-beta commented 1 day ago

no kernel 6.11 patch yet...

This issue seems has been resolved on current master, through this pr: https://github.com/johnfanv2/LenovoLegionLinux/pull/251

i-am-logger commented 1 day ago

awesome, missed that. well... i made the PR for 0.0.18

I wonder why my nix patch didn't work as I did the same...

there is a newer PR : https://github.com/NixOS/nixpkgs/pull/348417 i'll wait for this one to test.