`pip-on-top` GNOME extension doesn't work

4r7if3x commented 1 week ago

Describe the bug

The GNOME extension doesn't do what it's made for.

Steps To Reproduce

Steps to reproduce the behavior:

Install pip-on-top GNOME extension via Home-Manager:

{ ... }:

{
  home.packages = with pkgs; [
    gnomeExtensions.pip-on-top
  ];
}

Enable the extension.
Enable "Show on all workspaces" in the extension settings.
Open the web browser, Firefox in my case.
Open YouTube and play a video.
Change your browser tab.
- NOTE: This too is a problem. Switching Workspaces alone or Changing Windows won't turn on the Picture-in-Picture mode.

Expected behavior

After following the steps above, the Picture-in-Picture mode of the browser should be automatically turn on and continue to show you the playing video in a pop-up window.

Notify maintainers

@honnip @Rafostar

Metadata

[user@host:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.6.58, NixOS, 24.11 (Vicuna), 24.11.20241023.2768c7d`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.24.9`
 - channels(root): `"nixos-24.05"`
 - nixpkgs: `/nix/store/jsy7c2d1alj2gkxj36h794kk43d5601l-source`

Add a :+1: reaction to issues you find important.

Rafostar commented 1 week ago

Switching Workspaces alone or Changing Windows won't turn on the Picture-in-Picture mode (..) the browser should be automatically turn on and continue to show you the playing video in a pop-up window

The extension is not for turning on PiP automatically, nor for making normal browser tabs PiP windows. The sole purpose of the extension is to keep PiP windows on top and (optionally) on all workspaces. This was needed for Wayland session, cause unlike Xorg, it does not have such protocol implemented to do so. You still have to click the PiP button in browser.

4r7if3x commented 1 week ago

@Rafostar My bad, I've been busy minded and didn't think about this right. It's been some time since last I set this up the way I wanted. In combination with using you GNOME extension, I also had to enable "Picture-in-Picture: auto-open on tab switch" setting of Firefox itself. I appreciate your answer though, it helped me remember.

NixOS / nixpkgs