NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.06k stars 14.11k forks source link

Update request: signal-export 1.8.2 → 3.2.0 #353082

Open belamu opened 6 days ago

belamu commented 6 days ago

Notify maintainers @phaer @picnoir


Note for maintainers: Please tag this issue in your PR.


belamu commented 6 days ago

first draft in #353086

at least one dependency sqlcipher-wheel is missing. There I am not sure how to add it. See PR.

belamu commented 6 days ago

In the pyproject.toml of signal-export the python package versions are specified. I do not know yet how to pin them in the nix build default.nix as well but I would find it reasonable to do it. (nix newbie)

belamu commented 6 days ago

By the way (newbie-question): could some-one explain why I do not find signal-export in all-packages.nix as I expected after reading nixpkgs contributing Wiki article?

dotlambda commented 5 days ago

could some-one explain why I do not find signal-export in all-packages.nix as I expected after reading nixpkgs contributing Wiki article?

See https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md.

Btw, the official wiki is now hosted on https://wiki.nixos.org.

phaer commented 5 days ago

at least one dependency sqlcipher-wheel is missing. There I am not sure how to add it. See PR.

Looks reasonable simple to package, commented in the PR and will try to package sqlcipher3 soon.

In the pyproject.toml of signal-export the python package versions are specified. I do not know yet how to pin them in the nix build default.nix as well but I would find it reasonable to do it. (nix newbie)

You generally can't in nixpkgs. nixpkgs delivers one big python package set with one version per package. So no pinning needed.

The need to do so in some development scenarios is one of the reasons third-party projects such as poetry2nix, uv2nix, etc exist outside the tree.

belamu commented 5 days ago

could some-one explain why I do not find signal-export in all-packages.nix as I expected after reading nixpkgs contributing Wiki article?

See https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md.

Btw, the official wiki is now hosted on https://wiki.nixos.org.

Mentioned in new Wiki