search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.05k stars 14.09k forks source link

Update request: portmod 2.6.2 → 2.8.0 #353250

Open heraplem opened 4 days ago

heraplem commented 4 days ago

Notify maintainers

@marius851000

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

heraplem commented 3 days ago

Worth noting that 2.6.2 is broken due to #332957.

marius851000 commented 3 days ago

I’ve already an update (to 2.8.0) ready, but I’ve been waiting for https://gitlab.com/portmod/openmw-mods/-/merge_requests/587 and https://gitlab.com/portmod/openmw-mods/-/merge_requests/588/diffs to be merged (which aren’t as of now). Hopefully, I have workaround for both of them, so I’ll use that until they are merged.

marius851000 commented 3 days ago

So, here is my change: https://github.com/NixOS/nixpkgs/pull/353324 and it’s somewhat awkward, but it appears @zimward had also made an update at https://github.com/NixOS/nixpkgs/pull/353046

@zimward are you fine if you we focus on merging my PR? (I’ve done solid testing that it works well with graphical-overhauls and i-hearts-vanilla-director-cut)

zimward commented 2 days ago

Sure go ahead, i just closed the my PR.