NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.19k stars 14.2k forks source link

`useFetchCargoVendor` doesn't seem to respect `cargoRoot`? #356811

Open griffi-gh opened 3 hours ago

griffi-gh commented 3 hours ago

Describe the bug

useFetchCargoVendor tries to look up Cargo.lock in sourceRoot rather than sourceRoot/cargoRoot

Steps To Reproduce

Steps to reproduce the behavior:

  1. Create a package using rustPlatform.buildRustPackage, set cargoRoot to a subdir containing the Cargo.lock file

Expected behavior

Cargo.lock should be looked up in $sourceRoot/$cargoRoot

Screenshots

N/A

Additional context

N/A

Metadata

Notify maintainers


Note for maintainers: Please tag this issue in your PR.


Add a :+1: reaction to issues you find important.

griffi-gh commented 2 hours ago

350541

TomaSajt commented 1 hour ago

Keeping this open for better visibility. Will close when the PR is merged.