search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.41k stars 14.36k forks source link

Cannot use `desktopToDarwinBundle` with `libicns` #358719

Open Aleksanaa opened 1 week ago

Aleksanaa commented 1 week ago

With darwinMinVersionHook "10.13" added, the cli interface of icnsutil is changed, causing

https://github.com/NixOS/nixpkgs/blob/10c475aeb9d30451786d9d4319b4861dce7febca/pkgs/build-support/setup-hooks/desktop-to-darwin-bundle.sh#L192-L197

to be an invalid invocation.

An example of failure: https://logs.ofborg.org/?key=nixos/nixpkgs.356629&attempt_id=7b8665be-9766-4f1f-8013-d48f86c537c4

Notify maintainers

@NixOS/darwin-core

Note for maintainers: Please tag this issue in your PR.

Add a :+1: reaction to issues you find important.

emilazy commented 1 week ago

I’m confused; it doesn’t look like icnsutil has been changed in a long time? https://github.com/NixOS/nixpkgs/commits/master/pkgs/development/python-modules/icnsutil/default.nix

Aleksanaa commented 1 week ago

Figured out it's not, it's just because libicns also provides icnsutil which is actually a different command

emilazy commented 1 week ago

The hook should just @whatever@/bin/icnsutil, presumably.