NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.32k stars 14.3k forks source link

NOTONOTO pkgs does not add fonts #359013

Open Keyhoh opened 1 day ago

Keyhoh commented 1 day ago

Describe the bug

NOTONOTO pkgs does not add NOTONOTO fonts.

It should be fetched from github releases like Plemol-JP.

Steps To Reproduce

Steps to reproduce the behavior:

  1. add NOTONOTO pkgs
  2. run nixos-rebuild switch

Expected behavior

add NOTONOTO fonts

Screenshots

Screenshot_20241125_230423

Additional context

Metadata

Notify maintainers

@genga898


Note for maintainers: Please tag this issue in your PR.


Add a :+1: reaction to issues you find important.

genga898 commented 1 day ago

Here arre the fonts that are installed, check and see if they are installed on your machine, I seem to also be having the same issue

├── NotoSansJP-Black.ttf
├── NotoSansJP-Bold.ttf
├── NotoSansJP-ExtraBold.ttf
├── NotoSansJP-ExtraLight.ttf
├── NotoSansJP-Light.ttf
├── NotoSansJP-Medium.ttf
├── NotoSansJP-Regular.ttf
├── NotoSansJP-SemiBold.ttf
├── NotoSansJP-Thin.ttf
├── NotoSansMono-Black.ttf
├── NotoSansMono-Bold.ttf
├── NotoSansMono-ExtraBold.ttf
├── NotoSansMono_ExtraCondensed-Black.ttf
├── NotoSansMono_ExtraCondensed-Bold.ttf
├── NotoSansMono_ExtraCondensed-ExtraBold.ttf
├── NotoSansMono_ExtraCondensed-ExtraLight.ttf
├── NotoSansMono_ExtraCondensed-Light.ttf
├── NotoSansMono_ExtraCondensed-Medium.ttf
├── NotoSansMono_ExtraCondensed-Regular.ttf
├── NotoSansMono_ExtraCondensed-SemiBold.ttf
├── NotoSansMono_ExtraCondensed-Thin.ttf
├── NotoSansMono-ExtraLight.ttf
├── NotoSansMono-Light.ttf
├── NotoSansMono-Medium.ttf
├── NotoSansMono-Regular.ttf
├── NotoSansMono-SemiBold.ttf
├── NotoSansMono-Thin.ttf
└── SymbolsNerdFont-Regular.ttf
Keyhoh commented 1 day ago

Yes, the fonts installed.

NOTONOTO is a font that combines Noto Sans Mono and Noto Sans JP. Those fonts are for building NOTONOTO.

I think the code would look like this:

  pname = "notonoto";
  version = "0.0.3";

  src = fetchzip {
    url = "https://github.com/yuru7/NOTONOTO/releases/download/v${version}/NOTONOTO_v${version}.zip";
    hash = "sha256-s2B9QAjAkhzIaaB2oFGNJmzdhS7DdY9ZeQGAvWSClFA=";
  };

  installPhase = ''
    runHook preInstall

    install -Dm444 NOTONOTO/*.ttf -t $out/share/fonts/truetype/notonoto
    install -Dm444 NOTONOTO35/*.ttf -t $out/share/fonts/truetype/notonoto-35
    install -Dm444 NOTONOTOConsole/*.ttf -t $out/share/fonts/truetype/notonoto-console
    install -Dm444 NOTONOTO35Console/*.ttf -t $out/share/fonts/truetype/notonoto-35console

    runHook postInstall
  '';
  pname = "notonoto-hs";
  version = "0.0.3";

  src = fetchzip {
    url = "https://github.com/yuru7/NOTONOTO/releases/download/v${version}/NOTONOTO_HS_v${version}.zip";
    hash = "sha256-+vW2UUqWnhlRe5/da0M3OiA0j23xcKbnmwZ6OX4NDAQ=";
  };

  installPhase = ''
    runHook preInstall

    install -Dm444 NOTONOTO_HS/*.ttf -t $out/share/fonts/truetype/notonoto-hs
    install -Dm444 NOTONOTO35_HS/*.ttf -t $out/share/fonts/truetype/notonoto-hs-35
    install -Dm444 NOTONOTOConsole_HS/*.ttf -t $out/share/fonts/truetype/notonoto-hs-console
    install -Dm444 NOTONOTO35Console_HS/*.ttf -t $out/share/fonts/truetype/notonoto-hs-35console

    runHook postInstall
  '';