shairport-sync 4.3.4 crashes upon streaming

[lloeki]

Describe the bug

Segfault when attempting to stream.

Steps To Reproduce

Steps to reproduce the behavior:

1. enable shairport-sync service
2. stream to it
3. observe crash

Expected behavior

no crash

Screenshots

Dec 01 11:46:42 pi1 shairport-sync[788]: [SWR @ 0x7f6801dce0] Input channel layout "" is invalid or unsupported.
Dec 01 11:46:42 pi1 shairport-sync[788]: [SWR @ 0x7f6801dce0] Context has not been initialized
Dec 01 11:46:42 pi1 shairport-sync[788]: *** buffer overflow detected ***: terminated

Additional context

• Reported upstream: https://github.com/mikebrady/shairport-sync/issues/1937
• Caused by ffmpeg update
• Addressed upstream in development branch

This uses a version that works:

  nixpkgs.overlays = let
    shairport-sync-overlay-git = (final: prev: {
      shairport-sync = prev.shairport-sync.overrideAttrs (_: {
        version = "git";
        src = pkgs.fetchFromGitHub {
          repo = "shairport-sync";
          owner = "mikebrady";
          rev = "d8442c1afcd5f2871f024423495ddf205555f2d5";
          sha256 = "sha256-r4P1wToRsLPcMC+0UQ3yp4gDU89DpvEZWPLBiJsVDUg=";
        };
      });
    });

   shairport-sync-overlay-airplay2 = (final: prev: {
     shairport-sync = prev.shairport-sync.override { enableAirplay2 = true; };
   });
  in
    [ shairport-sync-overlay-git shairport-sync-overlay-airplay2 ]

Metadata

• system: "aarch64-linux"
• host os: Linux 6.6.31, NixOS, 24.11 (Vicuna), 24.11.20241128.c71ad5c
• multi-user?: yes
• sandbox: yes
• version: nix-env (Nix) 2.24.10
• channels(root): "nixos-24.05, nixos-hardware"
• nixpkgs: /nix/store/bm4ga8rzxqcydd16i39admpjwc01x94a-source

Notify maintainers

@LnL7 @jordanisaacs

---

Note for maintainers: Please tag this issue in your PR.

---

Add a :+1: reaction to issues you find important.

[jwillikers]

I would guess that this is related to ffmpeg 7, which requires changes that were made upstream but haven't been released yet. See https://github.com/mikebrady/shairport-sync/issues/1876 for reference. Oh wait, it seems you already have gotten that far in your upstream issue.

I should be able to look into backporting the necessary changes as a patch tomorrow for the package, unless someone gets to that first.

In the meantime, I've been using a newer commit to fix this. The overlay is here in case it helps.