Report undeclared gio-unix-2.0 upstream

jtojnar commented 6 years ago

The following projects fail to declare their dependency on gio-unix-2.0 headers, which produces errors like the following:

src/gcal-shell-search-provider-generated.c:15:12: fatal error: gio/gunixfdlist.h: No such file or directory
 #  include <gio/gunixfdlist.h>
            ^~~~~~~~~~~~~~~~~~~
compilation terminated.

dbus-player.c:22:10: fatal error: gio/gdesktopappinfo.h: No such file or directory
#include <gio/gdesktopappinfo.h>

../plugins/housekeeping/gsd-disk-space.c:32:10: fatal error: gio/gunixmounts.h: No such file or directory
 #include <gio/gunixmounts.h>

[ ] pkgs/applications/audio/audio-recorder/default.nix https://bugs.launchpad.net/audio-recorder/+bug/1784622
[x] pkgs/applications/backup/deja-dup/default.nix
[x] pkgs/applications/misc/zathura/core/default.nix
[x] pkgs/desktops/gnome-3/apps/gnome-calendar/default.nix https://gitlab.gnome.org/GNOME/gnome-calendar/issues/259
[x] pkgs/desktops/gnome-3/apps/gnome-photos/default.nix
[x] pkgs/desktops/gnome-3/apps/seahorse/default.nix https://gitlab.gnome.org/GNOME/seahorse/issues/8
[x] pkgs/desktops/gnome-3/core/baobab/default.nix
[ ] pkgs/desktops/gnome-3/core/evince/default.nix https://gitlab.gnome.org/GNOME/evince/issues/950
[x] pkgs/desktops/gnome-3/core/gnome-calculator/default.nix
[x] pkgs/desktops/gnome-3/core/gnome-desktop/default.nix https://gitlab.gnome.org/GNOME/gnome-desktop/issues/10
[x] pkgs/desktops/gnome-3/core/gnome-settings-daemon/default.nix https://gitlab.gnome.org/GNOME/gnome-settings-daemon/issues/16
[x] pkgs/desktops/gnome-3/core/gnome-software/default.nix https://gitlab.gnome.org/GNOME/gnome-software/issues/320
[x] pkgs/desktops/gnome-3/core/gnome-system-log/default.nix
[x] pkgs/desktops/gnome-3/core/gnome-user-share/default.nix https://gitlab.gnome.org/GNOME/gnome-user-share/issues/1
[x] pkgs/desktops/gnome-3/core/nautilus/default.nix https://gitlab.gnome.org/GNOME/nautilus/issues/287
[x] pkgs/desktops/gnome-3/core/totem/default.nix https://gitlab.gnome.org/GNOME/totem/issues/246
[ ] pkgs/desktops/mate/mate-applets/default.nix https://github.com/mate-desktop/mate-applets/issues/335
[ ] pkgs/desktops/mate/mate-panel/default.nix https://github.com/mate-desktop/mate-panel/issues/852
[ ] pkgs/desktops/xfce/core/xfce4-power-manager.nix https://bugzilla.xfce.org/show_bug.cgi?id=14587
[x] gnome-recipes https://gitlab.gnome.org/GNOME/recipes/issues/76
[ ] pkgs/applications/editors/gnome-latex/default.nix https://gitlab.gnome.org/GNOME/gnome-latex/issues/63
[x] gnome-flashback https://gitlab.gnome.org/GNOME/gnome-flashback/issues/3
[x] gnome-panel https://gitlab.gnome.org/GNOME/gnome-panel/issues/6
[x] gnome-applets https://gitlab.gnome.org/GNOME/gnome-applets/issues/3

We should report it upstream so they can fix it. Try building the package without the hack to see the error.

jtojnar commented 6 years ago

Incorrect poppler-glib headers:

[x] pkgs/desktops/gnome-3/core/tracker-miners/default.nix https://bugzilla.gnome.org/show_bug.cgi?id=795573

jtojnar commented 5 years ago

All offenders are reported, now we wait.

jtojnar commented 4 years ago

[x] xfce4-14.exo https://bugzilla.xfce.org/show_bug.cgi?id=15825

mkg20001 commented 4 years ago

[x] pkgs/desktops/cinnamon/cinnamon-screensaver
[x] pkgs/desktops/cinnamon/cinnamon-control-center
[ ] ~~pkgs/desktops/cinnamon/cinnamon-session~~
[x] pkgs/desktops/cinnamon/cinnamon-settings-daemon
[x] pkgs/desktops/cinnamon/cinnamon-nemo
[x] pkgs/desktops/cinnamon/xapps

nh2 commented 4 years ago

I found in https://github.com/NixOS/nixpkgs/pull/77979#discussion_r368708826 how

{
  mesonFlags = [
    # TODO: https://github.com/NixOS/nixpkgs/issues/36468
    "-Dc_args=-I${glib.dev}/include/gio-unix-2.0"
  ];
}

can be used instead of NIX_CFLAGS_COMPILE, which I think is superior and we should switch to it for meson based builds because

that way all parts of meson can see the flag, passing it to potentially more places than we do with our low-level hack
the flag shows up in the build logs, making it clear what's happening

worldofpeace commented 4 years ago

I found in #77979 (comment) how
{
  mesonFlags = [
    # TODO: https://github.com/NixOS/nixpkgs/issues/36468
    "-Dc_args=-I${glib.dev}/include/gio-unix-2.0"
  ];
}
can be used instead of NIX_CFLAGS_COMPILE, which I think is superior and we should switch to it for meson based builds because
* that way all parts of meson can see the flag, passing it to potentially more places than we do with our low-level hack

* the flag shows up in the build logs, making it clear what's happening

Thanks :heart: