search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.34k stars 14.3k forks source link

Report undeclared gio-unix-2.0 upstream #36468

Open jtojnar opened 6 years ago

jtojnar commented 6 years ago

The following projects fail to declare their dependency on gio-unix-2.0 headers, which produces errors like the following:

src/gcal-shell-search-provider-generated.c:15:12: fatal error: gio/gunixfdlist.h: No such file or directory
 #  include <gio/gunixfdlist.h>
            ^~~~~~~~~~~~~~~~~~~
compilation terminated.

dbus-player.c:22:10: fatal error: gio/gdesktopappinfo.h: No such file or directory
#include <gio/gdesktopappinfo.h>

../plugins/housekeeping/gsd-disk-space.c:32:10: fatal error: gio/gunixmounts.h: No such file or directory
 #include <gio/gunixmounts.h>

We should report it upstream so they can fix it. Try building the package without the hack to see the error.

jtojnar commented 6 years ago

Incorrect poppler-glib headers:

jtojnar commented 6 years ago

All offenders are reported, now we wait.

jtojnar commented 5 years ago
mkg20001 commented 5 years ago
nh2 commented 4 years ago

I found in https://github.com/NixOS/nixpkgs/pull/77979#discussion_r368708826 how

{
  mesonFlags = [
    # TODO: https://github.com/NixOS/nixpkgs/issues/36468
    "-Dc_args=-I${glib.dev}/include/gio-unix-2.0"
  ];
}

can be used instead of NIX_CFLAGS_COMPILE, which I think is superior and we should switch to it for meson based builds because

worldofpeace commented 4 years ago

I found in #77979 (comment) how

{
  mesonFlags = [
    # TODO: https://github.com/NixOS/nixpkgs/issues/36468
    "-Dc_args=-I${glib.dev}/include/gio-unix-2.0"
  ];
}

can be used instead of NIX_CFLAGS_COMPILE, which I think is superior and we should switch to it for meson based builds because

* that way all parts of meson can see the flag, passing it to potentially more places than we do with our low-level hack

* the flag shows up in the build logs, making it clear what's happening

Thanks :heart:

mwleeds commented 4 years ago

This is fixed in GNOME Recipes now.

masipcat commented 4 years ago
stale[bot] commented 4 years ago

I marked this as stale due to inactivity. → More info

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info

jtojnar commented 1 year ago

Xfce-power-manager (https://gitlab.xfce.org/xfce/xfce4-power-manager/-/issues/39) has patch available, targetting 4.18.2: https://gitlab.xfce.org/xfce/xfce4-power-manager/-/commit/cbb3e82172ef520d520c4744447889767ea1c2b7

rvl commented 9 months ago

I submitted a patch upstream for pkgs/applications/window-managers/phosh/default.nix: https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1363

bobby285271 commented 8 months ago

With https://github.com/xfce-mirror/xfce4-pulseaudio-plugin/commit/a7eb9b9a43b4b1b3256a2999f276ce7d6b764ca0, https://github.com/xfce-mirror/exo/commit/6600467166621462717f996942d81051b8d96473, https://github.com/xfce-mirror/xfce4-notifyd/commit/307c8641b38f5161096d9886f1539b7f58b309c9, https://github.com/xfce-mirror/ristretto/commit/f7758e38b14ee4e124f38ddf56095e9fef91457b, https://github.com/xfce-mirror/xfce4-docklike-plugin/commit/867124d716c43bb1894ff69d57ee93474fae483b, https://github.com/xfce-mirror/xfce4-session/commit/a8ed1746fb4aeae6436b4c7b3a58d2926b7c4323 and #298614 all gio-unix-2.0 workarounds in Xfce are either upstreamed or cleaned up now.

jtojnar commented 1 month ago