search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.64k stars 13.8k forks source link

Replace pycrypto with pycryptodome #43433

Closed timokau closed 6 years ago

timokau commented 6 years ago

Issue description

Apaprently pycrypto is long unmtaintained and has known vulnerabilities (https://github.com/dlitz/pycrypto/issues/176). Gentoo plans to remove that package (https://github.com/cschwan/sage-on-gentoo/issues/510). pycryptodome is a maintained fork that can be used as a (drop in?) replacement.

Should we follow gentoos example? @FRidh @dotlambda

Here are the affected files:

$ rg -l '\bpycrypto\b' 
doc/package-notes.xml
pkgs/top-level/python-packages.nix
pkgs/servers/kippo/default.nix
nixos/modules/services/networking/kippo.nix
pkgs/applications/graphics/screencloud/default.nix
pkgs/applications/misc/electron-cash/default.nix
pkgs/applications/misc/electrum/dash.nix
pkgs/applications/misc/electrum/default.nix
pkgs/applications/networking/pyload/default.nix
pkgs/applications/misc/jrnl/default.nix
pkgs/applications/misc/mysql-workbench/default.nix
pkgs/applications/misc/yubioath-desktop/default.nix
pkgs/applications/misc/yokadi/default.nix
pkgs/development/python-modules/ecpy/default.nix
pkgs/development/python-modules/flask-restful/default.nix
pkgs/development/python-modules/ldaptor/default.nix
pkgs/development/python-modules/ledgerblue/default.nix
pkgs/development/python-modules/pycrypto/default.nix
pkgs/development/python-modules/scapy/default.nix
pkgs/development/python-modules/python-axolotl/default.nix
pkgs/development/python-modules/patator/default.nix
pkgs/development/python-modules/thumbor/default.nix
pkgs/tools/admin/mycli/default.nix
pkgs/tools/X11/winswitch/default.nix
pkgs/tools/admin/salt/default.nix
pkgs/tools/admin/ansible/default.nix
pkgs/tools/X11/xpra/default.nix
pkgs/tools/backup/duplicity/default.nix
pkgs/tools/backup/obnam/default.nix
pkgs/tools/backup/s3ql/default.nix
pkgs/tools/security/knockknock/default.nix
pkgs/tools/security/volatility/default.nix
pkgs/tools/misc/svtplay-dl/default.nix
pkgs/tools/misc/yle-dl/default.nix
pkgs/tools/misc/yubikey-neo-manager/default.nix
pkgs/tools/misc/yubikey-neo-manager/fix-pyside-requirement.diff
pkgs/applications/networking/instant-messengers/gajim/default.nix
pkgs/applications/networking/instant-messengers/salut-a-toi/default.nix
pkgs/applications/networking/irc/weechat/default.nix
pkgs/applications/networking/p2p/tribler/default.nix
pkgs/applications/science/math/sage/python-openid.nix
pkgs/applications/version-management/git-and-tools/git-bz/default.nix
pkgs/tools/networking/p2p/tahoe-lafs/default.nix
xeji commented 6 years ago

:+1: Arch also provides pycryptodome as a drop-in alternative for pycrypto.

FRidh commented 6 years ago

Our pycrypto is actually pycryptodome https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/python-modules/pycrypto/default.nix

FRidh commented 6 years ago

Also, duplicate of https://github.com/NixOS/nixpkgs/issues/21671

timokau commented 6 years ago

Oh its great that that is already taken care of. Sorry I missed that.