NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.37k stars 13.59k forks source link

Add missing version numbers #43717

Open matthewbauer opened 6 years ago

matthewbauer commented 6 years ago

Some packages are missing version numbers. Here is the list:

jtojnar commented 6 years ago

There appear to be some false positives. At least the dleyna packages do have version.

dezgeg commented 6 years ago

Also a plenty of setup hooks and "helper" packages like nix-prefetch-git.

matthewbauer commented 6 years ago

Oops yeah I was using an older nixpkgs checkout to generate the list.

I've removed the setup hooks (see 74042ecc921956fa889ac4fa54a5898afcf8c92c). I'm not sure if nix-prefetch-* should be left out though. At least lots of people will install it directly into their environment and might be surprised when nix-env -u nix-prefetch-git doesn't update for them (even when it has been modified).

dezgeg commented 6 years ago

That's solved by nix-env -u --leq which you need to use anyway to ever get updates when the package's dependencies update.

pSub commented 6 years ago

Forgot to mention the issue number in commits bdcba71f9e7a2187e67738754ce7ca1a5b222533 and 5324d84423530bd58317f2af62357a2021b70dc8.

matthewbauer commented 6 years ago

That's solved by nix-env -u --leq which you need to use anyway to ever get updates when the package's dependencies update.

Thanks, I was not aware of that option! This list is autogenerated from this PR: https://github.com/NixOS/nixpkgs/pull/43718. I wonder if it would make sense to have some meta to mark these in some way? I added one for isHook but maybe it should be more generic. I would like to get to the point where we can apply this check in release.nix (as is done in the PR).

pSub commented 6 years ago

buildifier, buildozer and unused_deps are aliases for bazel-buildtools.

vaibhavsagar commented 6 years ago

What would be an appropriate version number for all-cabal-hashes?

matthewbauer commented 6 years ago

I would say the date of the snapshot would work. Not sure if that is available.

stale[bot] commented 4 years ago

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
suhr commented 8 months ago

A lot of packages have got their versions, so here's an updated list of packages with no versions:

suhr commented 8 months ago

And here's a much bigger list generated from nix search results: https://gist.github.com/suhr/84916990c36c79633f4e9dc1f57e5cae.

Overall 1084 packages have no version.

tomodachi94 commented 4 months ago

Adding the "tracking" label, since this is a long-lived issue for rolling out fixes tree-wide.