NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.21k stars 14.2k forks source link

Qtile missing optional python modules #45039

Open Melkor333 opened 6 years ago

Melkor333 commented 6 years ago

Issue description

The qtile derivation doesn't include optional modules like python-dbus, which is necessary for widgets like the notification-daemon, according to the official documentation.

There are also other missing modules which are not mentioned in the documentation, the full list would be:

Steps to reproduce

I think the best would be to add those modules as optional dependencies since they are not necessary for it to work but for some of the features.

gagbo commented 5 years ago

Would that explain why the SysTray widget does not appear ? I'm kind of confused right now.

Melkor333 commented 5 years ago

That's possible. If you start qtile from a console in debug mode you will see if errors appear. And it's probably because of that...

gagbo commented 5 years ago

I had only an error about not being able to create the dbus object and I wasn't too suspicious, but having qtile working fine on Fedora confirms that I need to add the dependencies somehow in NixOS

stale[bot] commented 4 years ago

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.
Melkor333 commented 4 years ago

@kamilchm FYI since you are the current maintainer of this package: I currently don't use qtile so I don't know if this is still an issue. It doesn't look like it's fixed to me, so I'll just leave this Issue open.

steveej commented 4 years ago

Running my config on 19aac2413ae2810a47850f165a592cbe0d06f744 requires me to add psutil to the pythonPath. Also as a an update to the OP here's a list of python packages that I could identify:

  qtile = self.nixpkgs-master.qtile.overrideAttrs(oldAttrs: {
    pythonPath = oldAttrs.pythonPath ++ (with self.python37Packages; [
      psutil
      dbus-python
      pyxdg
      mpd2
      # python-wifi
      # iwlib
      dateutil
      keyring
    ]);
  });

I couldn't identify the ones which are commented, however my config doesn't seem to rely on them anyway.

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info

Tanish2002 commented 1 year ago

iwlib and pythonwifi keyring are in nixpkgs now, and other modules have already been added. Can we these three final packages to qtile?

Tanish2002 commented 1 year ago

iwlib and pythonwifi keyring are in nixpkgs now, and other modules have already been added. Can we these three final packages to qtile?

Tagging qtile maintainers @arjan-s @kamilchm

Infinidoge commented 1 year ago

Took care of iwlib in #258510

arjan-s commented 1 year ago

What part of Qtile needs pythonwifi? I can see in the docs that the ImapWidget needs keyring, but I can't find anything about pythonwifi, and the WlanWidget works just fine without it.

Tanish2002 commented 1 year ago

@arjan-s I couldn't find anything as well. I guess I just looked at this and said it. iwlib and keyring were the only missing modules