NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.29k stars 14.27k forks source link

Updating the < xonsh > shell #48531

Closed abhi18av closed 6 years ago

abhi18av commented 6 years ago

Hi @r-ryantm ,

Could you please update the xonsh shell to 0.8.0 ? I think as of now it's quite outdated.

t184256 commented 6 years ago

0.8.0 felt kind of a bumpy release for me, but at this point any upgrade is welcome, I guess.

Also, once we're on the topic, here are some erratic tricks I use for my xonsh 0.8.0 overlay to make it startup faster, maybe some of these could be useful in the upstream packaging:

    postInstall = ''
      site_packages=$(python -c "import site; print(site.__file__.rsplit('/', 2)[-2])")
      xonsh=$out/lib/$site_packages/site-packages/xonsh/
      install -D -m644 xonsh/parser_table.py xonsh/__amalgam__.py $xonsh
      install -D -m644 xonsh/completers/__amalgam__.py $xonsh/completers/
      install -D -m644 xonsh/history/__amalgam__.py $xonsh/history/
      install -D -m644 xonsh/prompt/__amalgam__.py $xonsh/prompt/
      python -m compileall $xonsh
      python -O -m compileall $xonsh
    '';
    postFixup = ''
      substituteInPlace $out/bin/.xonsh-wrapped --replace 'python3.6m' 'python3.6m -O'
    '';
abhi18av commented 6 years ago

I understand @joachifm , please feel free to close this issue in that case.

joachifm commented 6 years ago

@abhi18av hm? I did not intend to indicate this should be closed.

ryantm commented 6 years ago

@abhi18av r-ryantm is a bot, if you want to talk to a person, please @ryantm

Here is the log that r-ryantm produced while trying to build xonsh (these logs are available at https://github.com/ryantm/nixpkgs-update/issues/62):

2018-10-03T04:54:49 xonsh 0.6.8 -> 0.7.10
2018-10-03T04:55:44 nix build failed.
tests/test_ptk_history.py s                                              [ 84%]
tests/test_ptk_multiline.py sssssss                                      [ 84%]
tests/test_python_completers.py ...........                              [ 85%]
tests/test_replay.py ...                                                 [ 85%]
tests/test_tools.py .................................................... [ 87%]
........................................................................ [ 89%]
........................................................................ [ 91%]
........................................................................ [ 94%]
........................................................................ [ 96%]
........................................................................ [ 98%]
...                                                                      [ 98%]
tests/test_vox.py .....                                                  [ 99%]
tests/test_wizard.py ....                                                [ 99%]
tests/test_xontribs.py ....                                              [ 99%]
tests/test_xoreutils.py ......                                           [ 99%]
tests/aliases/test_source.py ..                                          [ 99%]
tests/test_lib/test_collections.py ............                          [100%]

=================================== FAILURES ===================================
____________________________ xonsh test: test_indir ____________________________
xonsh execution failed
  File "/build/source/tests/test_lib/test_os.xsh", line 10, in test_indir
    assert ![pwd].output.strip() == tmpdir
AssertionError: 
----------------------------- Captured stdout call -----------------------------
/build/source
~/tmp6_3jsgky ~/source
/build/tmp6_3jsgky
~/source
======= 1 failed, 3039 passed, 26 skipped, 4 deselected in 30.06 seconds =======

2018-10-03T04:55:44 FAIL

Unfortunately, r-ryantm can only do basic updates of bumping version numbers and hashes, and when it bumps the version and hash of xonsh, it doesn't build. If someone fixes the build, r-ryantm will probably be able to do trivial updates that don't need new dependencies, compiler flags, etc.

marsam commented 6 years ago

I think we can close this, xonsh is packaged at 0.8.3 (latest release)

dywedir commented 6 years ago

Thanks!

abhi18av commented 6 years ago

Thanks!

On Mon, 26 Nov 2018, 00:41 Vladyslav M. <notifications@github.com wrote:

Closed #48531 https://github.com/NixOS/nixpkgs/issues/48531.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/NixOS/nixpkgs/issues/48531#event-1985507522, or mute the thread https://github.com/notifications/unsubscribe-auth/AMNNXkUMfPdxIAUKTxhd4V2mIILnS8Wlks5uyutFgaJpZM4XdsOR .