NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.37k stars 13.6k forks source link

Updating deis to teamhephy's fork #55709

Open WhittlesJr opened 5 years ago

WhittlesJr commented 5 years ago

Issue description

The original deis project has been in end-of-life status since January 2017 (1.13.4). This is the version that is currently packaged in nixpkgs. However, the torch was passed to a group called teamhephy, and they have continued the project into 2.XX.X.

I want to have the tool up-to-date, but I'm not sure whether to create a new package (called "deis-hephy" or something) or to update the existing deis package. It's supposedly not substantially changed from the original, and shouldn't be breaking, but since it's an "end-of-life" thing I'm hesitant to do that.

WhittlesJr commented 5 years ago

For reference, this is the overlay that I'm currently using to get what I want. This can / should become a package in nixpkgs, but I'd like to know if it would be alright to overwrite the existing nixpkgs/pkgs/development/tools/deis/default.nix or if I should submit it as a new package.

~/.config/nixpkgs/overlays/workflow-cli.nix

self: super:
with super;
{
  workflow-cli = buildGoPackage rec {
    name = "workflow-cli-${version}";
    version = "2.20.1";
    rev = "v${version}";

    goPackagePath = "github.com/teamhephy/workflow-cli";

    src = fetchFromGitHub {
      inherit rev;
      owner = "teamhephy";
      repo = "workflow-cli";
      sha256 = "0mq6q45vwksajmpk7mk1swx8pfhbz6rrnhdjmf225qxjyi47d29s";
    };

    # Override the build phase (to set buildFlags):
    buildPhase = ''
      runHook preBuild
      runHook renameImports
      cd go/src/${goPackagePath}
      go install -a -installsuffix cgo -ldflags="-X ${goPackagePath}/version.Version=${version}"
      runHook postBuild
    '';

    postInstall = ''
      mv $bin/bin/workflow-cli $bin/bin/deis
    '';

    goDeps = /home/alexj/Documents/Golang/src/github.com/teamhephy/workflow-cli/deps.nix;

    meta = with stdenv.lib; {
      homepage = https://teamhephy.info;
      description = "A command line utility used to interact with the Deis open source PaaS.";
      license = licenses.mit;
      platforms = platforms.linux;
      #maintainers = with maintainers; [
      #  WhittlesJr
      #];
    };
  };
}
stale[bot] commented 4 years ago

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.