vscode: integrate vscode with libdbusmenu

NixOS / nixpkgs

Nix Packages collection & NixOS

MIT License

16.43k stars 12.93k forks source link

vscode: integrate vscode with libdbusmenu #65680

Open pasqui23 opened 4 years ago

pasqui23 commented 4 years ago

Describe the bug Allow vscode and firefox support for libdbusmenu,like with libreoffice

To Reproduce Steps to reproduce the behavior:

Install vscode in KDE
Run code with "window.titleBarStyle": "native"

Expected behavior The title bar integrated in KDE's menu button

Screenshots Desktop 2_001

Additional context Add any other context about the problem here.

Metadata

system: "x86_64-linux"
host os: Linux 5.1.16, NixOS, 19.09pre186408.3d84cffe955 (Loris)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3pre20190712_aa82f8b
channels(root): "nixos-19.09pre186408.3d84cffe955"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: 
- vscode
- vscode-with-extensions
- vscodium
# a list of nixos modules affected by the problem
module:

pasqui23 commented 4 years ago

According to the AUR,it only need libdbusmenu for this to work properly,but I have added said package to both envieroment.systemPackages and services.dbus.packages to no avail.

brcha commented 4 years ago

I managed to get VSCode to have DBusMenu support by running it manually with

$ LD_LIBRARY_PATH=/nix/store/32ghafsr1wd8ghrmcmz308nrx781dvfs-libdbusmenu-gtk3-16.04.0/lib code

as seen in the screenshot:

Screenshot_20200212_015900

I'm a NixOS newb (installed nixos several days ago when I bought a new computer), but I am guessing that adding libdbusmenu-gtk3 as a dependency for vscode (in the generic.nix file, I guess) would fix the problem with global menus for both vscode and vscodium. That would, theoretically, fix the same problem for other apps that have a similar issue (possibly with -gtk2 or _qt packages instead).

pasqui23 commented 3 years ago

Still relevant,and https://github.com/NixOS/nixpkgs/pull/79889 still matter

nixos-discourse commented 3 years ago

This issue has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/549

pasqui23 commented 2 years ago

Still relevant

Artturin commented 1 year ago

assuming fixed by https://github.com/NixOS/nixpkgs/pull/100235

pasqui23 commented 1 year ago

Just built codium from master, https://github.com/NixOS/nixpkgs/pull/100235 did not fix this.

Artturin commented 1 year ago

Try libdbusmenu-gtk3 and make a pr If it works