NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.69k stars 13.14k forks source link

Decouple GNOME Shell from gnome-session #67546

Open jtojnar opened 4 years ago

jtojnar commented 4 years ago

Currently, gnome-session depends on Shell:

https://github.com/NixOS/nixpkgs/blob/7a4a8e008988b64059e7b8f1ee5e30c0102a36e4/pkgs/desktops/gnome-3/core/gnome-session/default.nix#L49

We do not want that as it introduces unnecessary dependencies into Flashback session. Also it will make things like gnome-shell-with-plugins or optional runtime dependencies much more convenient by dropping the need to rebuild.

We would need to include the session in a similar way we already do with flashback

https://github.com/NixOS/nixpkgs/blob/7a4a8e008988b64059e7b8f1ee5e30c0102a36e4/nixos/modules/services/x11/desktop-managers/gnome3.nix#L168-L175

instead of the hardcoded package

https://github.com/NixOS/nixpkgs/blob/7a4a8e008988b64059e7b8f1ee5e30c0102a36e4/nixos/modules/services/x11/desktop-managers/gnome3.nix#L141

We also need to be mindful of env var stripping.

stale[bot] commented 4 years ago

Thank you for your contributions.

This has been automatically marked as stale because it has had no activity for 180 days.

If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.

Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse.
  3. Ask on the #nixos channel on irc.freenode.net.