search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.36k stars 13.59k forks source link

Create vscodium-with-extensions #70624

Open turion opened 4 years ago

turion commented 4 years ago

Since https://github.com/NixOS/nixpkgs/issues/59028 there is the package vscodium. It accepts basically the same extensions as vscode, as far as I understand. It would be cool if there was vscodium-with-extensions that works the same as vscode-with-extensions. Ideally, a lot of code would be shared between these two functions, but I'm not sure how to do that. If you can provide some advice, I'm willing to try implementing it.

@eadwu @volth @matthewbauer @angristan

eadwu commented 4 years ago

From what I remember, vscode-with-extensions is just a wrapper script to set the extension directory to the derivation that contains the extensions so this shouldn't be that hard.

raboof commented 4 years ago

Yes, in fact you can already plug vscodium into vscode-with-extensions - I created https://nixos.wiki/wiki/VSCodium to document this. I guess we could create a pkgs.vscodium-with-extensions that already has that set as the default.

turion commented 4 years ago

I want to try this at some point soon

panda2134 commented 1 year ago

As nix refuses to install vscode-with-extensions by default due to licensing issues, creating vscodium-with-extensions actually makes sense (due to its MIT license).

tv42 commented 7 months ago

I'm using a pretty strict allowUnfreePredicate that does not include vscode, and vscode-with-extensions.override { vscode = vscodium; } works just fine for me, without complaints about non-free.