jtojnar
commented
5 years ago According to https://github.com/NixOS/nixpkgs/commit/bfb476c7d622d4d86142524974b4afb3c15bcc04 it is being patched to allow running tests in the builder chroot. But we are not running the tests there anyway due to other failures. I would just drop the whole checking code.
--- a/pkgs/applications/networking/p2p/gnunet/default.nix
+++ b/pkgs/applications/networking/p2p/gnunet/default.nix
@@ -21,31 +21,6 @@ stdenv.mkDerivation rec {
sqlite zlib libpulseaudio libopus libogg jansson
];
- preConfigure = ''
- # Brute force: since nix-worker chroots don't provide
- # /etc/{resolv.conf,hosts}, replace all references to `localhost'
- # by their IPv4 equivalent.
- find . \( -name \*.c -or -name \*.conf \) | \
- xargs sed -ie 's|\<localhost\>|127.0.0.1|g'
-
- # Make sure the tests don't rely on `/tmp', for the sake of chroot
- # builds.
- find . \( -iname \*test\*.c -or -name \*.conf \) | \
- xargs sed -ie "s|/tmp|$TMPDIR|g"
-
- sed -ie 's|@LDFLAGS@|@LDFLAGS@ $(Z_LIBS)|g' \
- src/regex/Makefile.in \
- src/fs/Makefile.in
- '';
-
- # unfortunately, there's still a few failures with impure tests
- doCheck = false;
- checkPhase = ''
- export GNUNET_PREFIX="$out"
- export PATH="$out/bin:$PATH"
- make -k check
- '';
-
meta = with stdenv.lib; {
description = "GNU's decentralized anonymous and censorship-resistant P2P framework";
The z_libs fix does not appear to be necessary either.
It would be nice if gnunet provided test suite that we could install and run in a VM, something like https://wiki.gnome.org/Initiatives/GnomeGoals/InstalledTests that many Freedesktop projects offer. We even support multi VM tests (e.g. https://github.com/NixOS/nixpkgs/blob/91b02cd86b09bdd3549663e81883a2c3a7e11961/nixos/tests/etcd-cluster.nix#L104-L156).
Alternately, make check could allow skipping tests that require features that are not available in our chroot.
cc maintainer @vrthra
ghost
stale[bot]
Mindavi
Hi,
I discovered a while ago that Nix for nixpkgs simply patches all references of localhost in our source. As I noted in https://bugs.gnunet.org/view.php?id=5894
My proposal for now is, revert the patching and try to work out with us (and ideally send patches) where we can help you to build and run tests in your restricted environment.
I'm happy to take any ideas from your side, to see what we can work out together.
Cheers, ng0 / GNUnet.