NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
16.53k stars 13.02k forks source link

lightdm-gtk-greeter background stays in i3 session #80040

Open ghost opened 4 years ago

ghost commented 4 years ago

Describe the bug After login to i3 session, lightdm background is still seen.

To Reproduce Steps to reproduce the behavior:

  1. enable i3
  2. ensure services.xserver.displayManager.lightdm.background is set (it is by default)
  3. ensure there is no wallpaper is set under xorg

Expected behavior There should be no background

Screenshots If applicable, add screenshots to help explain your problem. Screenshot_20200213_212528

Additional context The problem is seen on nixos-unstable https://github.com/NixOS/nixpkgs-channels/commit/a21c2fa3ea2b88e698db6fc151d9c7259ae14d96 and upper There was no such problem on https://github.com/NixOS/nixpkgs-channels/commit/e59dcf8ccec439f54dc52ffd5832610fc3f6c9c2

Metadata Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module:
worldofpeace commented 4 years ago

see https://github.com/NixOS/nixpkgs/commit/78d83650df6e6fbb0f94749787b89817c4269c8b

worldofpeace commented 4 years ago

We also agreed this is an issue with i3, and we shouldn't do anything special for all desktop managers for a bug in this window manager. You can still set it manually to black as the aforementioned commit message claims you can do.

primeos commented 4 years ago

Since this seems to still be an issue (other report): Maybe we should add a workaround in the i3 module?

From my other comment (https://github.com/NixOS/nixpkgs/pull/78346#issuecomment-583392204):

i3 can probably do nothing about this (as that should break ~/.xsession scripts and our extraSessionCommands without extra hacks) and the only thing we can do is probably to add ${pkgs.xorg.xsetroot}/bin/xsetroot -solid black to nixos/modules/services/x11/window-managers/i3.nix right before ${cfg.extraSessionCommands} (but this would only cover i3 and kinda restore the previous behaviour with the exception that it now runs before extraSessionCommands but it might still run after ~/.xsession (haven't looked into this)).

cc i3 maintainers: @modulistic @fpletz @globin and most frequent module committer @ericsagnes

Feel free to add your thoughts/opinions (I'm not using i3 anymore).

worldofpeace commented 4 years ago

In the i3 module would be fine.

ghost commented 4 years ago

@worldofpeace

see 78d8365

Missed that. Thank you!

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info