search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.96k stars 13.97k forks source link

bazel broken on darwin #80440

Closed marsam closed 4 years ago

marsam commented 4 years ago

Describe the bug bazel broken on darwin in nixpkgs HEAD (aba59a9) https://hydra.nixos.org/build/112616281

To Reproduce Steps to reproduce the behavior:

  1. try to build bazel on darwin
$ nix-build -A bazel
...
configuring
fixing libtool script ./third_party/protobuf/3.6.1/ltmain.sh
fixing libtool script ./third_party/protobuf/3.6.1/third_party/googletest/googlemock/build-aux/ltmain.sh
fixing libtool script ./third_party/protobuf/3.6.1/third_party/googletest/googletest/build-aux/ltmain.sh
no configure script, doing nothing
preBuildPhase
building
🍃  Building Bazel from scratch....../nix/store/gbsjyv1v6q0j3bnlpbnm34zvr7s340l0-clang-wrapper-6.0.1/bin/clang -Wno-deprecated-declarations -isystem /nix/store/5w2gzqgdkxchagx8kyc8g1m1i76jm4fc-python3-3.7.6/include -isystem /nix/store/s92svvqjkslsznfydhbcbssfwwqg5xkz-cctools-port-dev/include -isystem /nix/store/am25q2v54399z4zb24qy0jiw0y36gann-libc++-7.1.0/include -iframework /nix/store/zyxa0gvmp0ng884f2m2p6mxl1d0fwvmb-apple-framework-CoreFoundation/Library/Frameworks -iframework /nix/store/l3g2j10ap77dapf7mnpdg21anyyw874a-apple-framework-CoreServices/Library/Frameworks -iframework /nix/store/x5ys771vzvn58mrhzpf887xfkcp4s89b-apple-framework-CFNetwork/Library/Frameworks -iframework /nix/store/84qacqfpznaajgfmh2dsipnq7zb8v1hq-apple-framework-CoreAudio/Library/Frameworks -iframework /nix/store/f90rsgwnz4kxqfk37m8w6bmp0g6ww4qx-apple-framework-IOKit/Library/Frameworks -iframework /nix/store/p8ml6f2ziz7ihhygnznpn75ghiizqirk-apple-framework-CoreData/Library/Frameworks -iframework /nix/store/8q4gxd9q3vwj2jk54gha68iy95byskml-apple-framework-DiskArbitration/Library/Frameworks -iframework /nix/store/n2dm2i261qadgcw546kg2nkkz6zy878n-apple-framework-Security/Library/Frameworks -iframework /nix/store/zs03nr01ccbz5xcap4mb5nrg6ayrk01h-apple-framework-NetFS/Library/Frameworks -iframework /nix/store/7gnndd0dnsabw5w8riqs4bixhp0p513b-apple-framework-OpenDirectory/Library/Frameworks -iframework /nix/store/2vly8ax779iib90vvdd3p3yb6n03mls4-apple-framework-ServiceManagement/Library/Frameworks -iframework /nix/store/rkvd60vk8z5pbfr85vk7yd9rclsj22bb-apple-framework-Foundation/Library/Frameworks -isystem /nix/store/rkqjhnhnwj0f0wxrnpcqbgkinq9ay566-objc4-osx-10.12.6/include -iframework /nix/store/hkmzw3wv3zdriyl7qnp63jq1wfjm7mbm-apple-framework-ApplicationServices/Library/Frameworks -iframework /nix/store/5jpnx7ibidg5k6q0qjw16mqbpigqvd67-apple-framework-CoreText/Library/Frameworks -iframework /nix/store/qccl4pbpw4sz2m35k2yf5ayb814cg14h-apple-framework-CoreGraphics/Library/Frameworks -iframework /nix/store/a26s4yh1dza1l5kw6jm75na7hhpxqxkr-apple-framework-Accelerate/Library/Frameworks -iframework /nix/store/5zak65kp42wd2svls9ini1l68q2prz3w-apple-framework-CoreWLAN/Library/Frameworks -iframework /nix/store/lsgw306lp1xjm88difwjg0vqsvj7xc7k-apple-framework-SecurityFoundation/Library/Frameworks -iframework /nix/store/hzzfidhw83f8gr2fl554ifbfhq5bh2d8-apple-framework-IOBluetooth/Library/Frameworks -iframework /nix/store/yjcjap7y6abwwklwmzdbm1wb76ny39yv-apple-framework-IOSurface/Library/Frameworks -isystem /nix/store/p2wbyhn85h863iyapn0lm33h0y41pyqk-apple-lib-xpc/include -iframework /nix/store/2pfsf9v56sw8cscwj8d7kx52kd9w0k6j-apple-framework-SystemConfiguration/Library/Frameworks -iframework /nix/store/5gshq8z0axwl6fr1wwjldkwrxmbnbsmr-apple-framework-ImageIO/Library/Frameworks -isystem /nix/store/v0fv2lmlph48wgpiifrmn8jzizgj6j3h-libc++-6.0.1/include -isystem /nix/store/w7v2i4c95xj2llaip5m3ykhmvyw3vq34-libc++abi-6.0.1/include -isystem /nix/store/d8a22zfaqsdxv6v8r5l373x817lskz0j-compiler-rt-6.0.1-dev/include -isystem /nix/store/z60gn9y5n80mqbd2xjsff6xay0sr6j0j-zulu1.8.0_202-8.36.0.1/include -iframework /nix/store/2aiwnjmlwfb5zxgyzs4rhyq9v61vm15l-swift-corefoundation/Library/Frameworks -isystem /nix/store/5w2gzqgdkxchagx8kyc8g1m1i76jm4fc-python3-3.7.6/include -isystem /nix/store/s92svvqjkslsznfydhbcbssfwwqg5xkz-cctools-port-dev/include -isystem /nix/store/am25q2v54399z4zb24qy0jiw0y36gann-libc++-7.1.0/include -iframework /nix/store/zyxa0gvmp0ng884f2m2p6mxl1d0fwvmb-apple-framework-CoreFoundation/Library/Frameworks -iframework /nix/store/l3g2j10ap77dapf7mnpdg21anyyw874a-apple-framework-CoreServices/Library/Frameworks -iframework /nix/store/x5ys771vzvn58mrhzpf887xfkcp4s89b-apple-framework-CFNetwork/Library/Frameworks -iframework /nix/store/84qacqfpznaajgfmh2dsipnq7zb8v1hq-apple-framework-CoreAudio/Library/Frameworks -iframework /nix/store/f90rsgwnz4kxqfk37m8w6bmp0g6ww4qx-apple-framework-IOKit/Library/Frameworks -iframework /nix/store/p8ml6f2ziz7ihhygnznpn75ghiizqirk-apple-framework-CoreData/Library/Frameworks -iframework /nix/store/8q4gxd9q3vwj2jk54gha68iy95byskml-apple-framework-DiskArbitration/Library/Frameworks -iframework /nix/store/n2dm2i261qadgcw546kg2nkkz6zy878n-apple-framework-Security/Library/Frameworks -iframework /nix/store/zs03nr01ccbz5xcap4mb5nrg6ayrk01h-apple-framework-NetFS/Library/Frameworks -iframework /nix/store/7gnndd0dnsabw5w8riqs4bixhp0p513b-apple-framework-OpenDirectory/Library/Frameworks -iframework /nix/store/2vly8ax779iib90vvdd3p3yb6n03mls4-apple-framework-ServiceManagement/Library/Frameworks -iframework /nix/store/rkvd60vk8z5pbfr85vk7yd9rclsj22bb-apple-framework-Foundation/Library/Frameworks -isystem /nix/store/rkqjhnhnwj0f0wxrnpcqbgkinq9ay566-objc4-osx-10.12.6/include -iframework /nix/store/hkmzw3wv3zdriyl7qnp63jq1wfjm7mbm-apple-framework-ApplicationServices/Library/Frameworks -iframework /nix/store/5jpnx7ibidg5k6q0qjw16mqbpigqvd67-apple-framework-CoreText/Library/Frameworks -iframework /nix/store/qccl4pbpw4sz2m35k2yf5ayb814cg14h-apple-framework-CoreGraphics/Library/Frameworks -iframework /nix/store/a26s4yh1dza1l5kw6jm75na7hhpxqxkr-apple-framework-Accelerate/Library/Frameworks -iframework /nix/store/5zak65kp42wd2svls9ini1l68q2prz3w-apple-framework-CoreWLAN/Library/Frameworks -iframework /nix/store/lsgw306lp1xjm88difwjg0vqsvj7xc7k-apple-framework-SecurityFoundation/Library/Frameworks -iframework /nix/store/hzzfidhw83f8gr2fl554ifbfhq5bh2d8-apple-framework-IOBluetooth/Library/Frameworks -iframework /nix/store/yjcjap7y6abwwklwmzdbm1wb76ny39yv-apple-framework-IOSurface/Library/Frameworks -isystem /nix/store/p2wbyhn85h863iyapn0lm33h0y41pyqk-apple-lib-xpc/include -iframework /nix/store/2pfsf9v56sw8cscwj8d7kx52kd9w0k6j-apple-framework-SystemConfiguration/Library/Frameworks -iframework /nix/store/5gshq8z0axwl6fr1wwjldkwrxmbnbsmr-apple-framework-ImageIO/Library/Frameworks -isystem /nix/store/v0fv2lmlph48wgpiifrmn8jzizgj6j3h-libc++-6.0.1/include -isystem /nix/store/w7v2i4c95xj2llaip5m3ykhmvyw3vq34-libc++abi-6.0.1/include -isystem /nix/store/d8a22zfaqsdxv6v8r5l373x817lskz0j-compiler-rt-6.0.1-dev/include -isystem /nix/store/z60gn9y5n80mqbd2xjsff6xay0sr6j0j-zulu1.8.0_202-8.36.0.1/include -iframework /nix/store/2aiwnjmlwfb5zxgyzs4rhyq9v61vm15l-swift-corefoundation/Library/Frameworks -isystem /nix/store/am25q2v54399z4zb24qy0jiw0y36gann-libc++-7.1.0/include/c++/v1 -macosx_version_min 10.12 -sdk_version 10.12 -no_uuid -L/nix/store/5w2gzqgdkxchagx8kyc8g1m1i76jm4fc-python3-3.7.6/lib -L/nix/store/am25q2v54399z4zb24qy0jiw0y36gann-libc++-7.1.0/lib -L/nix/store/rkqjhnhnwj0f0wxrnpcqbgkinq9ay566-objc4-osx-10.12.6/lib -L/nix/store/v0fv2lmlph48wgpiifrmn8jzizgj6j3h-libc++-6.0.1/lib -L/nix/store/w7v2i4c95xj2llaip5m3ykhmvyw3vq34-libc++abi-6.0.1/lib -L/nix/store/c6yzg47yv6zdqbc68gj9zhs26mgxay9c-compiler-rt-6.0.1/lib -L/nix/store/5w2gzqgdkxchagx8kyc8g1m1i76jm4fc-python3-3.7.6/lib -L/nix/store/am25q2v54399z4zb24qy0jiw0y36gann-libc++-7.1.0/lib -L/nix/store/rkqjhnhnwj0f0wxrnpcqbgkinq9ay566-objc4-osx-10.12.6/lib -L/nix/store/v0fv2lmlph48wgpiifrmn8jzizgj6j3h-libc++-6.0.1/lib -L/nix/store/w7v2i4c95xj2llaip5m3ykhmvyw3vq34-libc++abi-6.0.1/lib -L/nix/store/c6yzg47yv6zdqbc68gj9zhs26mgxay9c-compiler-rt-6.0.1/lib -F/nix/store/zyxa0gvmp0ng884f2m2p6mxl1d0fwvmb-apple-framework-CoreFoundation/Library/Frameworks -F/nix/store/l3g2j10ap77dapf7mnpdg21anyyw874a-apple-framework-CoreServices/Library/Frameworks -F/nix/store/rkvd60vk8z5pbfr85vk7yd9rclsj22bb-apple-framework-Foundation/Library/Frameworks -framework CoreFoundation -mmacosx-version-min=10.9 -fobjc-arc -framework CoreServices -framework Foundation -o /private/tmp/nix-build-bazel-2.0.0.drv-0/bazel_03tEzdn4/archive/xcode-locator tools/osx/xcode_locator.m
clang-6.0: error: unknown argument: '-macosx_version_min'
clang-6.0: error: unknown argument: '-sdk_version'
clang-6.0: error: unknown argument: '-no_uuid'
clang-6.0: error: no such file or directory: '10.12'
clang-6.0: error: no such file or directory: '10.12'
./bazel_src/scripts/generate_bash_completion.sh: line 71: ./bazel_src/output/bazel: No such file or directory
builder for '/nix/store/9vyz42zw7666ancqg23k96l3wk86pqvw-bazel-2.0.0.drv' failed with exit code 127
error: build of '/nix/store/9vyz42zw7666ancqg23k96l3wk86pqvw-bazel-2.0.0.drv' failed

Expected behavior Able to build bazel on darwin

Additional context might be related to https://github.com/NixOS/nixpkgs/pull/77632

Metadata Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.

 - system: `"x86_64-darwin"`
 - host os: `Darwin 16.7.0, macOS 10.12.6`
 - multi-user?: `yes`
 - sandbox: `no`
 - version: `nix-env (Nix) 2.3.2`
 - channels(marsam): `"home-manager-path"`
 - channels(root): `""`
 - nixpkgs: `/Users/marsam/code/nix-config/nixpkgs`

Maintainer information:

# a list of nixpkgs attributes affected by the problem
attribute: bazel
# a list of nixos modules affected by the problem
module:

cc: @mboes

LnL7 commented 4 years ago

The bazel build is passing LDFLAGS flags to the compiler instead of the linker. Those should be prefixed with -Wl, or moved somewhere else.

https://github.com/NixOS/nixpkgs/blob/43a775649ce6c8a6d2b1d7bea8ccccd6eac72468/pkgs/development/tools/build-managers/bazel/default.nix#L345

uri-canva commented 4 years ago

Clang used as a frontend should accept linker flags.

uri-canva commented 4 years ago

Flags were added in a826b49c97bcc9d8365b5d18aeec8087116d195d.