NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.58k stars 13.74k forks source link

Packaging request: Jami desktop client #83411

Closed jluttine closed 2 years ago

jluttine commented 4 years ago

Project description

Jami (formerly GNU Ring) is an app for video/audio calls/conferences. It works p2p and has end-to-end encryption. It has clients for all major operating systems (Linux, WIndows, iOS, Android).

Nixpkgs already includes the daemon app although it's still named as Ring: https://github.com/NixOS/nixpkgs/issues/64009

Metadata

doronbehar commented 4 years ago

@jluttine I've been putting effort into this and I have managed to build jami-daemon today. But this required some upstream patches, and other patches to Nixpkgs. So as a start, I need review for: https://github.com/NixOS/nixpkgs/pull/94560 & https://github.com/NixOS/nixpkgs/pull/94460

Once I'll get these two PRs merged on Nixpkgs and I'll get https://github.com/savoirfairelinux/opendht/pull/510 merged, everything should be ready to open a PR for jami-daemon.

doronbehar commented 4 years ago

Update: now the desktop client and the client library build, but the daemon fails to run: https://git.jami.net/savoirfairelinux/ring-daemon/issues/275 and without the daemon (dring), the desktop client is unusable. I've tried to apply the overrides that Guix applies:

https://git.savannah.gnu.org/cgit/guix.git/tree/gnu/packages/jami.scm?id=master#n141

Among which are -fPIC related cflags for ffmpeg and pjsip, but unfortunately they don't work - adding them doesn't make dring run:

==27318==ASan runtime does not come first in initial library list; you should either link runtime to your application or manually preload it with LD_PRELOAD.

I'm leaving this quest for now, unless somebody has an idea.

alpmestan commented 4 years ago

Hello,

@nschoe and I looked into packaging up Jami a few months ago and went as far as being able to run the daemon and GUI client. We could create an account, exchange messages, but dring would crash pretty easily (could be when one of us started typing, when we tried to make a call, etc). So obviously this is not perfect. But we did spend a whoooole lot of time scanning Jami's build system, so perhaps you'll find the Nix code we had useful?

Anyway, here's what we had: https://github.com/alpmestan/jami.nix

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info

infinisil commented 3 years ago

Still relevant

pinpox commented 3 years ago

Any updates on this, is someone working on it? I'm still interested in using it.

There seem to be multiple "desktop clients"

The gnome one is the one with recent activity, would it be enough to package that one to get working jami?

viric commented 3 years ago

I have a fork of that set of nix expressions and it worked for me.

https://github.com/viric/jami.nix

On Tue, May 18, 2021 at 04:27:02AM -0700, Pablo Ovelleiro Corral wrote:

Any updates on this, is someone working on it? I'm still interested in using it.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/NixOS/nixpkgs/issues/83411#issuecomment-843087938

-- (Escriu-me xifrat si saps PGP / Write ciphered if you know PGP) PGP key 7CBD1DA5 - https://emailselfdefense.fsf.org/

kevincox commented 3 years ago

Is there anything preventing it from being included in nixpkgs? I think there would be a lot of people would would appreciate that.

viric commented 3 years ago

These were my experiments and that may have to be a bit more polished. And polishing for nixpkgsI'm not very good at but I welcome anyone bringing that to nixpkgs.

On Tue, May 18, 2021 at 06:04:03AM -0700, Kevin Cox wrote:

Is there anything preventing it from being included in nixpkgs? I think there would be a lot of people would would appreciate that.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/NixOS/nixpkgs/issues/83411#issuecomment-843152666

-- (Escriu-me xifrat si saps PGP / Write ciphered if you know PGP) PGP key 7CBD1DA5 - https://emailselfdefense.fsf.org/

bqv commented 3 years ago

Of course someone manages this just after i move to Guix 😩

infinisil commented 3 years ago

@viric Since you haven't pinned the nixpkgs in that repo, which version are you using with it?

linsui commented 2 years ago

I'm going to open a PR later. You can test it in https://github.com/linsui/nixpkgs/tree/jami. It seems audio and video are broken.

kevincox commented 2 years ago

Feel free to tag me for review+merge. It would be nice to get audio+video working but I'm also not opposed to merging the basics now and fixing things in follow ups.

viric commented 2 years ago

@Infinisil oh I missed the question. I guess I used the nixpkgs of the date of the commit files.

@linsui video/audio worked for me in my last attempt.

linsui commented 2 years ago

Ah, the audio and video works well after I enable the turn. Looks like it's my network that jami can't establish the connect.