search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.58k stars 13.73k forks source link

Add libedit to clang-tools-extra #85217

Open deliciouslytyped opened 4 years ago

deliciouslytyped commented 4 years ago

clang-query requires libedit for tab completion.

deliciouslytyped commented 4 years ago

Clang-tools extra is not actually a separate package, and consists of extracting the source into the clang build https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/llvm/10/clang/default.nix

Looks like all versions should get it but I didn't check; https://reviews.llvm.org/D2200

Or do we deliberately minimize the clang dependencies? @ggreif @dtzWill - because git blame on 10 and 9

deliciouslytyped commented 4 years ago

Ok I'm not actually sure how to get this to work, adding editline to clangs inputs does not seem to be it. Might be LLVM since "lineeditor" is an LLVM component.

deliciouslytyped commented 4 years ago

I guess I was looking at a patch that got obsoleted by https://reviews.llvm.org/D2263 . I'm not sure what the end result is yet.

deliciouslytyped commented 4 years ago

It turns out that the lineeditor component is part of llvm, and rebuilding llvm like so, fixes the issue;

nix-shell -I nixpkgs=channel:nixos-unstable -p "(llvmPackages_10.extend (self: super: { llvm = super.llvm.overrideAttrs (old: { buildInputs = old.buildInputs ++ [ pkgs.libedit ]; }); })  ).clang-unwrapped" -v
stale[bot] commented 3 years ago

Hello, I'm a bot and I thank you in the name of the community for opening this issue.

To help our human contributors focus on the most-relevant reports, I check up on old issues to see if they're still relevant. This issue has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

The community would appreciate your effort in checking if the issue is still valid. If it isn't, please close it.

If the issue persists, and you'd like to remove the stale label, you simply need to leave a comment. Your comment can be as simple as "still important to me". If you'd like it to get more attention, you can ask for help by searching for maintainers and people that previously touched related code and @ mention them in a comment. You can use Git blame or GitHub's web interface on the relevant files to find them.

Lastly, you can always ask for help at our Discourse Forum or at #nixos' IRC channel.

lf- commented 6 months ago

This is still a problem. cc @dtzWill @Ericson2314 @lovek323 @alyssais @RaitoBezarius @rrbutani @sternenseemann as maintainers.

I am guessing it is unintentional that this is the case?