NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
18.31k stars 14.27k forks source link

pidgin: better plugin support #8999

Open vcunat opened 9 years ago

vcunat commented 9 years ago

Currently some things are searched on a wrong place. Noticed by @akaWolf. gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/fcj5mra7lqh2qd3wmcfkwhwq8iihfv6a-pidgin-2.10.11/share/pixmaps/pidgin/protocols/16/vkontakte.png: Failed to open file '/nix/store/fcj5mra7lqh2qd3wmcfkwhwq8iihfv6a-pidgin-2.10.11/share/pixmaps/pidgin/protocols/16/vkontakte.png': No such file or directory

Most likely, our patch for setting plugin search path will need to get improved.

vcunat commented 9 years ago

Another example (from duplicate issue): sipe plugin not finding share/pixmaps/pidgin/protocols/16/sipe.png.

deepfire commented 8 years ago

@vcunat a local group of NixOS users (including me) seems unable to use SIPE at all, when it's installed via nix-env.

vcunat commented 8 years ago

I'm sorry, I don't expect to find time to investigate that.

deepfire commented 8 years ago

Oddly, my later comments didn't make it.. or I have dreamed writing them : -)

In short -- pidgin works as expected -- pidgin-with-plugins is what was actually needed!

Maybe we should rename pidgin/pidgin-without-plugins -> pidgin-without-plugins/pidgin ?

vcunat commented 8 years ago

@deepfire: pushed cc174b3.

deepfire commented 8 years ago

@vcunat, thank you a lot!

deepfire commented 8 years ago

Question, where could one find documentation about ex-pidgin-with-plugins usage?

vcunat commented 8 years ago

@deepfire: it's just pidgin attribute that you can .override { plugins = [ .... ]; }. I believe there's no documentation about the way it's plugged-in, and it's really trivial ATM.

castilma commented 7 years ago

for me, pidgin-with-plugins and pidginotr (installed through nix-env) did not simply work(it wasnt listed under 'plugins'). if someone else has troubles installing it: with help from #nixos i succeded with #13248.

not sure, if thats the kind of problem you want to remove with this issue, though.

prusnak commented 4 years ago

@vcunat is this still a thing?

stale[bot] commented 4 years ago

I marked this as stale due to inactivity. → More info

ony commented 3 years ago

Issue with icons still there:

(02:32:28) gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/22/sipe.png: Failed to open file “/nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/22/sipe.png”: No such file or directory
(02:32:29) gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/sipe.png: Failed to open file “/nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/sipe.png”: No such file or directory
(02:32:29) gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/slack.png: Failed to open file “/nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/slack.png”: No such file or directory
(02:32:29) gtkutils: gdk_pixbuf_new_from_file() returned nothing for file /nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/telegram.png: Failed to open file “/nix/store/yf2rh51p477y9rhjjmynfmp5m6bhli66-pidgin-2.13.0/share/pixmaps/pidgin/protocols/16/telegram.png”: No such file or directory
DanielSiepmann commented 2 years ago

From my understanding: Pidgin is not intended to work with nix in that regard. Nix already patches pidgin to support plugins the nix way. I guess pidgin also needs to be patched in order to add the sources (images) from plugins to its own search path: https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/networking/instant-messengers/pidgin/add-search-path.patch