search

NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.35k stars 13.58k forks source link

Switch xml2 to debian repo #92909

Open petersjt014 opened 4 years ago

petersjt014 commented 4 years ago

The tool xml2 is currently fetched from, according to the package:

url = "https://web.archive.org/web/20160427221603/http://download.ofb.net/gale/xml2-0.5.tar.gz"

This does not feel like a great idea.

I suggest moving to the repo here, which seems to be identical anyway. This would both be good practice and make the tool itself updateable (I want to write it a man page eventually, once I reverse engineer it).

samueldr commented 4 years ago

Leaving some thoughts I left on IRC.

 <samueldr> I'm plenty comfortable with the source of xml2 being fetched from archive.org
 <samueldr> the hash is the same
 <samueldr> in fact, more comfortable than an arbitrary repo cloner
 <samueldr> now, what might be a better source with the optics of getting bug fixes is whatever debian is doing
 <samueldr> https://tracker.debian.org/pkg/xml2 -> https://salsa.debian.org/debian/xml2
 <samueldr> though other than an added manpage, it looks like the source is unchanged and unpatched

IMO, if archive.org becomes an issue, it could be changed to the debian.org repo. Or any other known trustable mirror for code. (Ideally using the exact same tarball as the release did)

petersjt014 commented 4 years ago

Yeah, the debian one does look better. Thanks for spotting that.

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info