NixOS / nixpkgs

Nix Packages collection & NixOS
MIT License
17.3k stars 13.54k forks source link

Some cursor themes contain empty cursor files (numix-cursor-theme, capitaine-cursors) #98481

Open stephaneyfx opened 3 years ago

stephaneyfx commented 3 years ago

Describe the bug Some cursor packages (e.g. numix-cursor-theme and capitaine-cursors) contain zero-byte cursor files, causing applications to fall back to the default X cursor theme.

To Reproduce Build the numix-cursor-theme package.

nix-build 'https://github.com/NixOS/nixpkgs/archive/master.tar.gz' -A numix-cursor-theme

Inspect the resulting files in result/share/icons/Numix-Cursor/cursors.

ls -l result/share/icons/Numix-Cursor/cursors

Expected behavior The cursor files are valid (notably not empty).

Actual behavior The cursor files are empty (size of zero bytes).

Additional context The issue started with commit 35deaa45a182d18858ae56c300ab786bdb6cb621. Other packages are affected (e.g. capitaine-cursors). The build output contains errors and warnings:

# For numix-cursor-theme
Unknown option -f
FAIL: src/config/alias.cursor xcursorgen: PNG error while reading x1/alias.png

# For capitaine-cursors
Warning: Option --without-gui= is deprecated
Unknown option -e
xcursorgen: PNG error while reading x1/alias.png

This reproduces the issue:

nix-build 'https://github.com/NixOS/nixpkgs/archive/35deaa45a182d18858ae56c300ab786bdb6cb621.tar.gz' -A numix-cursor-theme

The generated cursor files are valid with the previous commit:

nix-build 'https://github.com/NixOS/nixpkgs/archive/a45e68be364d751414a406bf78fadf9b60f8c606.tar.gz' -A numix-cursor-theme

Notify maintainers @jtojnar

Metadata

Maintainer information:

# a list of nixpkgs attributes affected by the problem (non-exhaustive)
attribute:
  - numix-cursor-theme
  - capitaine-cursors
jtojnar commented 3 years ago

It turns out that https://gitlab.com/inkscape/inkscape/-/merge_requests/2056 did not re-introduce all of the legacy flags – it does not support using long options without equal sign and the short aliases.

I would suggest either patching the build script as described in https://github.com/NixOS/nixpkgs/issues/86930 or adding the other legacy options to Inkscape.

stephaneyfx commented 3 years ago

Thank you for your answer. I submitted a PR to numix-cursor-theme. Regarding capitaine-cursors, it looks like there's already a fix in the upstream repository but no new release yet.

stale[bot] commented 3 years ago

I marked this as stale due to inactivity. → More info