NixOS / npm2nix

Generate nix expressions to build npm packages
MIT License
57 stars 32 forks source link

Fix git rev-parse for certain cases #14

Closed abbradar closed 10 years ago

abbradar commented 10 years ago

Without this, npm2nix would fail for, for example, parsoid with git rev-parse error.

abbradar commented 10 years ago

Looks like npm2nix would need some additional patches for this to work fully, don't merge this yet. I'm sorry for being hasty.

abbradar commented 10 years ago

That's it. When branch is specified after "#", we should perform checkout first, so local branch gets created and rev-parse works on it. Checked also for tag specifications, and built corresponding packages to be sure it works.

svanderburg commented 10 years ago

I've encountered the same problem in the reengineering branch. I also made a fix there. Could you also give that a shot? This branch is supposed to become the successor of the current implementation.

abbradar commented 10 years ago

It finishes successfully and resulting nix looks legit; guess we can close this then.

abbradar commented 9 years ago

Is there any ETA for moving to the reengineering? I have a package that needs this fix to be built out of tree for a long time now ^_^

offlinehacker commented 9 years ago

I don't like reenginering because it's complicated and slow. This is fixed already. Actually we have parsoid in nixpkgs.

abbradar commented 9 years ago

It is indeed fixed, thanks! grep shows nothing about parsoid on master though -- maybe I'm missing something?

offlinehacker commented 9 years ago

Oh, looks like I forgot to commit these changes, will do this today.