Closed abbradar closed 10 years ago
Looks like npm2nix would need some additional patches for this to work fully, don't merge this yet. I'm sorry for being hasty.
That's it. When branch is specified after "#", we should perform checkout first, so local branch gets created and rev-parse works on it. Checked also for tag specifications, and built corresponding packages to be sure it works.
I've encountered the same problem in the reengineering branch. I also made a fix there. Could you also give that a shot? This branch is supposed to become the successor of the current implementation.
It finishes successfully and resulting nix looks legit; guess we can close this then.
Is there any ETA for moving to the reengineering? I have a package that needs this fix to be built out of tree for a long time now ^_^
I don't like reenginering because it's complicated and slow. This is fixed already. Actually we have parsoid in nixpkgs.
It is indeed fixed, thanks! grep
shows nothing about parsoid
on master though -- maybe I'm missing something?
Oh, looks like I forgot to commit these changes, will do this today.
Without this, npm2nix would fail for, for example, parsoid with git rev-parse error.