search

NixOS / npm2nix

Generate nix expressions to build npm packages
MIT License
57 stars 31 forks source link

scoped packages still fail #48

Open erictapen opened 7 years ago

erictapen commented 7 years ago

Just tried to apply npm2nix on Abricotine.

May it be, that npm2nix has troubles with that @ in the dependency name?

npm2nix package.json default.nix
...
Error during fetch: Could not find version matching ^0.9.2 for @shagstrom/split-pane in undefined
erictapen commented 7 years ago

Had a look for npm package name format and discovered that this is about scoped packages. Fix from #37 changed behavior but brought no help unfortunately.

As I see it right, npm2nix generates the following URLs for querying the registry:

https://registry.npmjs.org/@shagstrom/split-pane/ with #37 fix on commit 5a8e210c20756aecc00fce6f79ed8d494cff5aca
https://registry.npmjs.org/%2540shagstrom%252Fsplit-pane on version 5.12.0

Both URLs return with an error. I have no experience with npm or JavaScript at all, but I found this comment, which suggests to replace the slash with an %2f. When I apply this to my URL, it shows a good result: https://registry.npmjs.org/@shagstrom%2fsplit-pane/.

Apperently, it should be like this.