Fetch backlogs only when needed...

NixOS / ofborg-viewer

MIT License

7 stars 5 forks source link

Fetch backlogs only when needed... #11

Closed samueldr closed 6 years ago

samueldr commented 6 years ago

Logs are (un?)expectedly large. This is compounded by the fact that ofborg-viewer shows all attempts. This can balloon up to expectedly large * n sizes.

Waiting to until a tab is shown to load the backlog would alleviate those concerns, while making (historic) logs fetching a bit longer.

See this build for a problematic build:

https://logs.nix.ci/?key=nixos/nixpkgs.34477&attempt_id=fa8d9fac-15c7-4075-ac3b-9455b4923473

This makes my chrome browser on my workstation (64GB ram) show a kill screen for the tab.

samueldr commented 6 years ago

A fix for this is currently deployed in the de-facto staging area

https://nix.samueldr.com/temp/?key=nixos/nixpkgs.34477&

Loading this page should work.

Loading the fa8d9* tab should cause the browser to hang.

That is because:

~/tmp $ wc fa8d9fac-15c7-4075-ac3b-9455b4923473
  243939  1208764 24657961 fa8d9fac-15c7-4075-ac3b-9455b4923473

Yes, around ¼ a million dom nodes are needed for this to work.

The next step is #13.